Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update obsolete privacy concerns about throwing errors early #2134

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Update obsolete privacy concerns about throwing errors early #2134

merged 1 commit into from
Sep 24, 2024

Conversation

emlun
Copy link
Member

@emlun emlun commented Sep 4, 2024 •
edited by pr-preview bot
Loading

Given the conclusions in #2132 (comment) and #2132 (comment), update the respective privacy concerns and remove the obsolete restrictions against returning "NotAllowedError" before the timeout expires. This simplifies some aspects of #2095 and #2096 (see: #2095 (comment)).

Closes #2132.

The following tasks have been completed:

  • [ ] Modified Web platform tests (No applicable tests)

Implementation commitment:

  • (This change only removes restrictions, but does not require action from implementers.)

Documentation and checks

Preview | Diff

MasterKale
MasterKale approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@MasterKale MasterKale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for wading into this and modernizing these privacy concerns. This'll definitely simplify discussions around adding new errors to WebAuthn.

@nadalin nadalin added this to the L3-WD-02 milestone Sep 12, 2024
@nadalin nadalin added the @Risk Items that are at risk for L3 label Sep 12, 2024
timcappalli
timcappalli approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@timcappalli timcappalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emlun emlun merged commit adf7a95 into main Sep 24, 2024
2 checks passed
@emlun emlun deleted the issue-2132-obsolete-privacy-cons branch September 24, 2024 16:15
github-actions bot added a commit that referenced this pull request Sep 24, 2024
@emlun @github-actions
Merge pull request #2134 from w3c/issue-2132-obsolete-privacy-cons
7150729 
SHA: adf7a95
Reason: push, by emlun

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshayku akshayku akshayku approved these changes

@selfissued selfissued selfissued approved these changes

@timcappalli timcappalli timcappalli approved these changes

@MasterKale MasterKale MasterKale approved these changes

@agl agl agl approved these changes

@pascoej pascoej Awaiting requested review from pascoej

Assignees

@emlun emlun

Labels
@Risk Items that are at risk for L3 subtype:impl-cons type:technical
Projects
None yet
Milestone
L3-WD-02
Development

Successfully merging this pull request may close these issues.

Review privacy concerns around error conditions
7 participants
@emlun @agl @MasterKale @timcappalli @selfissued @akshayku @nadalin