Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify behaviour of duplicate hints #2145

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

emlun
Copy link
Member

@emlun emlun commented Sep 11, 2024

Closes #2135.

The following tasks have been completed:

Implementation commitment:

Documentation and checks

  • Affects privacy
  • Affects security
  • Updated explainer

Preview | Diff

Copy link
Member

@nsatragno nsatragno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thanks!

Copy link
Member

@timcappalli timcappalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@nadalin nadalin added this to the L3-WD-02 milestone Sep 12, 2024
@nadalin nadalin added the @Risk Items that are at risk for L3 label Sep 12, 2024
@timcappalli timcappalli merged commit 7cd6269 into main Sep 24, 2024
2 checks passed
@timcappalli timcappalli deleted the issue-2135-duplicate-hints branch September 24, 2024 16:09
github-actions bot added a commit that referenced this pull request Sep 24, 2024
SHA: 7cd6269
Reason: push, by timcappalli

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@emlun
Copy link
Member Author

emlun commented Sep 24, 2024

@agl @nsatragno Would Chromium want a bug opened for this or is there no need?

@nsatragno
Copy link
Member

nsatragno commented Sep 24, 2024 via email

@emlun
Copy link
Member Author

emlun commented Sep 24, 2024

I don't think there's a reliable way to tell what the behaviour is other than inspecting the source code, so... would you like to check or should I open the bug first?

@nsatragno
Copy link
Member

nsatragno commented Sep 24, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify behaviour of duplicate hints
6 participants