Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate CollectedClientData.crossOrigin in RP ops #2166

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

emlun
Copy link
Member

@emlun emlun commented Oct 1, 2024

Fixes #2113.


Preview | Diff

Copy link
Contributor

@sbweeden sbweeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking "request changes" until @emlun confirms whether the wording around created is appropriate for the use in section 7.2 (verifying an assertion)

index.bs Outdated Show resolved Hide resolved
@emlun emlun requested a review from sbweeden October 9, 2024 18:18
@nadalin nadalin requested a review from agl October 23, 2024 18:13
Copy link
Contributor

@sbweeden sbweeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emlun emlun merged commit 3c506d4 into main Oct 28, 2024
2 checks passed
@emlun emlun deleted the issue-2113-rp-ops-crossOrigin branch October 28, 2024 13:58
github-actions bot added a commit that referenced this pull request Oct 28, 2024
SHA: 3c506d4
Reason: push, by emlun

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CollectedClientData.crossOrigin not referenced in RP ops
7 participants