Fix encoding and syntax highlighting of example code #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `<pre>` sometimes causes some characters to be converted into others. This is especially apparent in CDDL examples, where for example the first single quote in `foo = h'001122'` gets converted into "’" (U+2019) instead of "'" (U+0027), which is incorrect and also breaks CDDL syntax highlighting. See the [Bikeshed documentation][1] for more on using `<xmp>`. [1]: https://speced.github.io/bikeshed/#xmp
timcappalli
approved these changes
Oct 7, 2024
akshayku
approved these changes
Oct 7, 2024
MasterKale
approved these changes
Oct 9, 2024
selfissued
approved these changes
Oct 9, 2024
github-actions bot
added a commit
that referenced
this pull request
Oct 9, 2024
SHA: cfa7333 Reason: push, by selfissued Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
<pre>sometimes causes some characters to be converted into others. This is especially apparent in CDDL examples, where for example the first single quote infoo = h'001122'gets converted into "’" (U+2019) instead of "'" (U+0027), which is incorrect and also breaks CDDL syntax highlighting.This PR also fixes the syntax highlighting tags on some incorrectly tagged or untagged examples.
See the Bikeshed documentation for more on using
<xmp>.Preview | Diff