Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract macros for referring to [[Create]] and [[DiscoverFromExternalSource]] #2179

Merged
merged 7 commits into from
Oct 9, 2024

Conversation

emlun
Copy link
Member

@emlun emlun commented Oct 7, 2024

It's really cumbersome to have to list out the parameter list in every reference, but omitting the parameters also omits them from the rendered link, so that doesn't seem right either.

This also fixes some inconsistencies in parameter lists between references to
these methods.


Preview | Diff

…Source]]

This also fixes some inconsistencies in parameter lists between references to
these methods.
@emlun emlun self-assigned this Oct 7, 2024
@emlun emlun added this to the L3-WD-02 milestone Oct 7, 2024
Remove apparent reference to non-existent [[Get]] internal method
Copy link
Contributor

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved during the 9-Oct-24 call

@selfissued selfissued merged commit b253c3b into main Oct 9, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Oct 9, 2024
SHA: b253c3b
Reason: push, by selfissued

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@emlun emlun deleted the internal-method-macros branch October 9, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants