-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract macros for referring to [[Create]] and [[DiscoverFromExternalSource]] #2179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Source]] This also fixes some inconsistencies in parameter lists between references to these methods.
…of get() internals
timcappalli
approved these changes
Oct 8, 2024
Remove apparent reference to non-existent [[Get]] internal method
MasterKale
approved these changes
Oct 9, 2024
akshayku
approved these changes
Oct 9, 2024
selfissued
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved during the 9-Oct-24 call
github-actions bot
added a commit
that referenced
this pull request
Oct 9, 2024
SHA: b253c3b Reason: push, by selfissued Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's really cumbersome to have to list out the parameter list in every reference, but omitting the parameters also omits them from the rendered link, so that doesn't seem right either.
This also fixes some inconsistencies in parameter lists between references to
these methods.
Preview | Diff