Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove apparent reference to non-existent [[Get]] internal method #2180

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Remove apparent reference to non-existent [[Get]] internal method #2180

merged 4 commits into from
Oct 9, 2024

Conversation

emlun
Copy link
Member

@emlun emlun commented Oct 7, 2024 •
edited by pr-preview bot
Loading

Closes #2169.

Preview | Diff

@emlun emlun added this to the L3-WD-02 milestone Oct 7, 2024
@emlun emlun self-assigned this Oct 7, 2024
@emlun emlun changed the title Issue 2169 no credman get Remove apparent reference to non-existent [[Get]] internal method Oct 7, 2024
nsatragno
nsatragno reviewed Oct 7, 2024
View reviewed changes
index.bs Outdated Show resolved Hide resolved
@emlun emlun requested a review from nsatragno October 7, 2024 15:12
nsatragno
nsatragno approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@nsatragno nsatragno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@emlun
Copy link
Member Author

emlun commented Oct 7, 2024

Force-pushed to cut out commits 00fbea5 - 639c935 whose combination was the empty diff.

selfissued
selfissued approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved during the 9-Oct-24 call

@selfissued selfissued merged commit 9942c9c into internal-method-macros Oct 9, 2024
2 checks passed
@emlun emlun deleted the issue-2169-no-credman-get branch October 9, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshayku akshayku akshayku approved these changes

@selfissued selfissued selfissued approved these changes

@timcappalli timcappalli timcappalli approved these changes

@MasterKale MasterKale MasterKale approved these changes

@nsatragno nsatragno nsatragno approved these changes

Assignees

@emlun emlun

Labels
subtype:credman type:editorial
Projects
None yet
Milestone
L3-WD-02
Development

Successfully merging this pull request may close these issues.
6 participants
@emlun @nsatragno @MasterKale @timcappalli @selfissued @akshayku