Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove apparent reference to non-existent [[Get]] internal method #2180

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Remove apparent reference to non-existent [[Get]] internal method #2180

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
39da7b1
Remove apparent reference to non-existent [[Get]] internal method
emlun Oct 7, 2024
c258674
Change "Method" to "Internal Method" in headings where appropriate
emlun Oct 7, 2024
8d76185
Simplify reference to default [[CollectFromCredentialStore]]
emlun Oct 7, 2024
068d7f5
Add reference to #sctn-discover-from-external-source from discussion …
emlun Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1739,7 +1739,7 @@ To support obtaining assertions via {{CredentialsContainer/get()|navigator.crede
</xmp>


### Create a New Credential - PublicKeyCredential's <dfn for="PublicKeyCredential" method>[CREATE-METHOD-DEF]</dfn> Method ### {#sctn-createCredential}
### Create a New Credential - PublicKeyCredential's <dfn for="PublicKeyCredential" method>[CREATE-METHOD-DEF]</dfn> Internal Method ### {#sctn-createCredential}

<div link-for-hint="PublicKeyCredential/[CREATE-METHOD]">
{{PublicKeyCredential}}'s [=interface object=]'s implementation of the {{Credential/[CREATE-METHOD]}} [=internal method=] [[!CREDENTIAL-MANAGEMENT-1]] allows
Expand Down Expand Up @@ -2301,7 +2301,7 @@ The following [=simple exceptions=] can be raised:

</dl>

### Use an Existing Credential to Make an Assertion - PublicKeyCredential's `[[Get]](options)` Method ### {#sctn-getAssertion}
### Use an Existing Credential to Make an Assertion ### {#sctn-getAssertion}

[=[WRPS]=] call <code><a idl for="CredentialsContainer" lt="get()">navigator.credentials.get({publicKey:..., ...})</a></code> to
discover and use an existing [=public key credential=], with the [=user consent|user's consent=]. [=[RP]=] script optionally specifies some criteria
Expand All @@ -2318,9 +2318,10 @@ should be available without [=user mediation=] (roughly, this specification's [=
exactly one of those, it then calls <code>PublicKeyCredential.{{PublicKeyCredential/[DISCOVER-METHOD]}}</code> to have
the user select a [=public key credential source=].

Since this specification requires an [=authorization gesture=] to create any [=assertions=], the <code>PublicKeyCredential.<dfn
for="PublicKeyCredential" method>\[[CollectFromCredentialStore]](origin, options, sameOriginWithAncestors)</dfn></code> [=internal method=] inherits the default behavior of
{{Credential/[[CollectFromCredentialStore]]()|Credential.[[CollectFromCredentialStore]]()}}, of returning an empty set.
Since this specification requires an [=authorization gesture=] to create any [=assertions=],
{{PublicKeyCredential}} inherits the default behavior of
{{Credential/[[CollectFromCredentialStore]](origin, options, sameOriginWithAncestors)}}, of returning an empty set.
{{PublicKeyCredential}}'s implementation of {{PublicKeyCredential/[DISCOVER-METHOD]}} is specified in the next section.

In general, the user agent SHOULD show some UI to the user to guide them in selecting and authorizing an authenticator with which
to complete the operation. By setting <code>|options|.{{CredentialRequestOptions/mediation}}</code> to {{CredentialMediationRequirement/conditional}}, [=[RPS]=] can indicate that a prominent modal UI should <i>not</i> be shown <i>unless</i> credentials are discovered.
Expand All @@ -2333,7 +2334,7 @@ Any
{{CredentialsContainer/get()|navigator.credentials.get()}} operation can be aborted by leveraging the {{AbortController}};
see [[dom#abortcontroller-api-integration]] for detailed instructions.

#### PublicKeyCredential's <code><dfn for="PublicKeyCredential" method>[DISCOVER-METHOD-DEF]</dfn></code> Method #### {#sctn-discover-from-external-source}
#### PublicKeyCredential's <code><dfn for="PublicKeyCredential" method>[DISCOVER-METHOD-DEF]</dfn></code> Internal Method #### {#sctn-discover-from-external-source}

<div link-for-hint="PublicKeyCredential/[DISCOVER-METHOD]">

Expand Down Expand Up @@ -2855,7 +2856,7 @@ The following [=simple exceptions=] can be raised:

</dl>

### Store an Existing Credential - PublicKeyCredential's `[[Store]](credential, sameOriginWithAncestors)` Method ### {#sctn-storeCredential}
### Store an Existing Credential - PublicKeyCredential's `[[Store]](credential, sameOriginWithAncestors)` Internal Method ### {#sctn-storeCredential}

<div link-for-hint="PublicKeyCredential/[[Store]](credential, sameOriginWithAncestors)">

Expand Down