Skip to content

Commit

Permalink
Remove dead writes to CryptoKey.extractable in HKDF/PBKDF2.importKey (#…
Browse files Browse the repository at this point in the history
…379)

When these steps execute, it is know due to an earlier step that the
argument 'extractable' is false, and that the internal slot will not be
read before being overwritten again by SubtleCrypto.importKey:

https://w3c.github.io/webcrypto/#SubtleCrypto-method-importKey

Therefore, it is a dead write. Removing it makes it more similar to all
other importKey operations, which do not write the [[extractable]]
internal slot either.
  • Loading branch information
BenWiederhake authored Oct 25, 2024
1 parent d278fcb commit 85a4826
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions spec/Overview.html
Original file line number Diff line number Diff line change
Expand Up @@ -13206,12 +13206,6 @@ <h4>Operations</h4>
|key| to {{KeyType/"secret"}}.
</p>
</li>
<li>
<p>
Set the {{CryptoKey/[[extractable]]}} internal slot of
|key| to `false`.
</p>
</li>
<li>
<p>
Let |algorithm| be a new
Expand Down Expand Up @@ -13407,12 +13401,6 @@ <h4>Operations</h4>
|key| to {{KeyType/"secret"}}.
</p>
</li>
<li>
<p>
Set the {{CryptoKey/[[extractable]]}} internal slot of
|key| to `false`.
</p>
</li>
<li>
<p>
Let |algorithm| be a new {{KeyAlgorithm}}
Expand Down

0 comments on commit 85a4826

Please sign in to comment.