From 85a4826977731f0e7952f6876946a042d5697098 Mon Sep 17 00:00:00 2001 From: Ben Wiederhake Date: Fri, 25 Oct 2024 12:47:25 +0200 Subject: [PATCH] Remove dead writes to CryptoKey.extractable in HKDF/PBKDF2.importKey (#379) When these steps execute, it is know due to an earlier step that the argument 'extractable' is false, and that the internal slot will not be read before being overwritten again by SubtleCrypto.importKey: https://w3c.github.io/webcrypto/#SubtleCrypto-method-importKey Therefore, it is a dead write. Removing it makes it more similar to all other importKey operations, which do not write the [[extractable]] internal slot either. --- spec/Overview.html | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/spec/Overview.html b/spec/Overview.html index f57a0bf..1b85fdb 100644 --- a/spec/Overview.html +++ b/spec/Overview.html @@ -13206,12 +13206,6 @@

Operations

|key| to {{KeyType/"secret"}}.

-
  • -

    - Set the {{CryptoKey/[[extractable]]}} internal slot of - |key| to `false`. -

    -
  • Let |algorithm| be a new @@ -13407,12 +13401,6 @@

    Operations

    |key| to {{KeyType/"secret"}}.

  • -
  • -

    - Set the {{CryptoKey/[[extractable]]}} internal slot of - |key| to `false`. -

    -
  • Let |algorithm| be a new {{KeyAlgorithm}}