Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nonsensical test in AES-CBC export key operation #375

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

BenWiederhake
Copy link
Collaborator

@BenWiederhake BenWiederhake commented Oct 25, 2024

Closes #374

Since this is a pure spec bug (I believe), there is no need to track issues in implementations.

EDIT: I guess the easiest way to move forward is to mark this change as non-substantive? I'm unsure, please clarify.

Copy link
Member

@twiss twiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks like a copy+paste mistake. Thanks!

@twiss
Copy link
Member

twiss commented Oct 25, 2024

And indeed, could you mark the change as non-substantive in https://labs.w3.org/repo-manager/pr/id/w3c/webcrypto/375?

@w3cbot
Copy link

w3cbot commented Oct 25, 2024

BenWiederhake marked as non substantive for IPR from ash-nazg.

@BenWiederhake
Copy link
Collaborator Author

Done.

Also, there seems to be a cute UI glitch in that website:
Bildschirmfoto_2024-10-25_10-40-55

@twiss
Copy link
Member

twiss commented Oct 25, 2024

Thanks!
And, interesting; at least it seems to have worked :)

@twiss twiss merged commit d68a54a into w3c:main Oct 25, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Oct 25, 2024
SHA: d68a54a
Reason: push, by twiss

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@BenWiederhake BenWiederhake deleted the dev-aescbc-exportkey-create-new-jwk branch October 25, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AES-CBC export operation checks non-existent variable
3 participants