Remove dead writes to CryptoKey.extractable in HKDF/PBKDF2.importKey #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When these steps execute, it is know due to an earlier step that the argument 'extractable' is false, and that the internal slot will not be read before being overwritten again by SubtleCrypto.importKey: https://w3c.github.io/webcrypto/#SubtleCrypto-method-importKey Therefore, it is a dead write. Removing it makes it more similar to all other importKey operations, which do not write the [[extractable]] internal slot either.
|
BenWiederhake marked as non substantive for IPR from ash-nazg. |
BenWiederhake
added a commit
to BenWiederhake/ladybird
that referenced
this pull request
Oct 25, 2024
This corresponds to a recent change in the spec: w3c/webcrypto#379
gmta
pushed a commit
to LadybirdBrowser/ladybird
that referenced
this pull request
Oct 25, 2024
This corresponds to a recent change in the spec: w3c/webcrypto#379
Grubre
pushed a commit
to Grubre/ladybird
that referenced
this pull request
Oct 26, 2024
This corresponds to a recent change in the spec: w3c/webcrypto#379
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When these steps execute, it is know due to an earlier step that the argument 'extractable' is false, and that the internal slot will not be read before being overwritten again by SubtleCrypto.importKey:
https://w3c.github.io/webcrypto/#SubtleCrypto-method-importKey
Therefore, it is a dead write. Removing it makes it more similar to all other importKey operations, which do not write the [[extractable]] internal slot either.
Closes #377
As it is a dead write, there is no change in behavior. (Or at least there should be no change in behavior; maybe my reasoning is buggy, but I don't expect it.)
As such, there is no need to extend/adapt the WPT tests. Also, these tests already cover the
extractableslot extensively.Preview | Diff