Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: merge *-types as idl-type #578

Closed
wants to merge 1 commit into from
Closed

Conversation

saschanaz
Copy link
Member

This should make implementing #570 easier since every IDL type object will have the same type string.

This patch closes #537 and includes:

  • A relevant test
  • A relevant documentation update

This should make implementing #570 easier since every IDL type object will have the same type string.
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but it almost makes type: idl-type kinda meaningless... should we maybe just remove it? What's the expected fallout from this breaking change on WPT and ReSpec (I think we use it in ReSpec too)?

@saschanaz
Copy link
Member Author

Closing, I guess something like instanceof IDLType should do the work.

@saschanaz saschanaz closed this Jul 17, 2021
@saschanaz saschanaz deleted the remove-typetype branch July 17, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promise<T> uses return-type in an inconsistent way; union types don't use type at all
2 participants