-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add powerEfficient[En/De]coder (#666) and fingerprint mitigations (#675). #670
Conversation
Please take another look @youennf, @vr000m and @alvestrand. I've added the sentence from #675 to both powerEfficientEncoder and encoderImplementation (and dec). |
FYI @eshrubs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, modulo the language around permissions
@youennf Are you happy with the current fingerprinting language? |
The fingerprinting mitigation sounds like an improvement to me. |
@pes10k what are your thoughts on this PR? By not exposing unless deep user interaction such as the context capturing (requires user to approve a capture prompt) this limits the ability for a web app to use this for fingerprinting to a context where more sensitive information is already exposed (VC use case). |
@henbos thank you for this. Just to check my understanding, this would effectively only reveal these endpoints to the page if the user had already given the page permission to access at least one protected device, is that correct? If so, i think thats a fine mitigation and works well enough to protect users from most realistic passive fingerprinters. If i've misunderstood though, could you please kindly correct me? |
Correct, you would also need to currently be capturing (e.g. microphone or camera). For a page to be granted permissions for capture, the user would need to have accepted a browser permissions prompt. |
Whether the decoder currently used is considered power | ||
efficient by the user agent. This SHOULD reflect if the | ||
configuration results in hardware acceleration, but the user | ||
agent MAY take other information into account when deciding if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have examples of such information? Is it to cover the case of small resolutions for instance where some OSes may decide to go with software implementations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It gives implementations some wiggle-room, like if a HW implementation isn't performant we could still report false without violating the spec. I don't know if this is a real problem in practise though.
I also think that it is OK for an implementation to say that SW is power efficient if the resolution is so small that SW would be more performant than HW, but I don't think finding that cutoff point is required of the implementation.
Thanks @henbos for the explanation, i think this is a great change |
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy with this doc. Suggesting a refinement.
Fixes #666, #675
Preview | Diff