Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repositories.json #3481

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Conversation

AllstaRawR
Copy link
Contributor

Added FILFY Wabbajack to the repo list on line 64.

Added FILFY Wabbajack to the repo list on line 64.
Fixed error on lines 63 and 64 when adding my list.
@SovnSkyrim
Copy link
Contributor

SovnSkyrim commented Apr 5, 2024

That's a cool name but it cannot be named that way for the machine url
[xUnit.net 00:00:00.90] MachineUrl/ModlistRepository is not valid! Allowed Characters are: 0-9, A-Z, a-z, _ and - use https://regex101.com/r/cVYtyA/2to test: "F.I.L.F.Y." ("F.I.L.F.Y.")

Recommended fix: since this is only used internally; "filfy" should be enough.

Let me know here when you've edited it

@SovnSkyrim SovnSkyrim self-assigned this Apr 5, 2024
Updated line 64 to remove periods.
@AllstaRawR
Copy link
Contributor Author

That's a cool name but it cannot be named that way for the machine url [xUnit.net 00:00:00.90] MachineUrl/ModlistRepository is not valid! Allowed Characters are: 0-9, A-Z, a-z, _ and - use https://regex101.com/r/cVYtyA/2to test: "F.I.L.F.Y." ("F.I.L.F.Y.")

Recommended fix: since this is only used internally; "filfy" should be enough.

Let me know here when you've edited it

I have updated it to FILFY now. Thank you for explaining the issue. I'm new to anything to do with GitHub. :)

@SovnSkyrim SovnSkyrim merged commit 839c5a5 into wabbajack-tools:master Apr 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants