Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repositories.json to add Listonomicon #3485

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

ajaxxxxxxxx
Copy link
Contributor

@SovnSkyrim
Copy link
Contributor

[xUnit.net 00:00:01.16] Xunit.Sdk.TrueException: MachineUrl/ModlistRepository is not valid! Allowed Characters are: 0-9, A-Z, a-z, _ and - use https://regex101.com/r/cVYtyA/2to test: "Listonomicon/Listonomicon" ("Listonomicon")

Your machine URL is not valid.

This is used internally to separate the list from others, id suggest putting "listonomicon" in there.

Your readme is very lackluster, you'll have a lot of complains (and so will we in the support discord); I'd heavily suggest checking how other lists have it setup.

The only blocking thing for the merge is the machineURL error for now.

@SovnSkyrim SovnSkyrim self-assigned this Apr 13, 2024
@ajaxxxxxxxx
Copy link
Contributor Author

Thank you. I incorporated the feedback (see the link to our google doc of install instructions now in the readme) and replaced the machineURL with just "Listonomicon." Please let me know if this satisfies your concerns on the readme and fixes the issues with the pull request. Thanks!

@SovnSkyrim
Copy link
Contributor

Checks have passed now. Congratz.

@SovnSkyrim SovnSkyrim merged commit b7dc4ee into wabbajack-tools:master Apr 13, 2024
1 check passed
@ajaxxxxxxxx ajaxxxxxxxx deleted the patch-1 branch April 14, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants