Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repositories.json #3508

Merged
merged 3 commits into from
May 19, 2024
Merged

Conversation

PsychoticNM
Copy link
Contributor

No description provided.

@TDarkShadow TDarkShadow self-assigned this May 18, 2024
Copy link
Contributor

@TDarkShadow TDarkShadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For legacy sake, we ask you to put your repository below / last, and not at the top.

@@ -1,4 +1,5 @@
{
"WildCardFNV": "https://raw.githubusercontent.com/PsychoticNM/Wild-Card-FNV/main/modlists.json",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For legacy sake, we ask you to put your repository below / last, and not at the top.

Copy link
Contributor

@TDarkShadow TDarkShadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 more things you need to fix and we can accept the PR.

@@ -63,4 +62,6 @@
"VivaNewVegas": "https://raw.githubusercontent.com/Ungeziefi/VNV-Wabbajack/main/modlists.json",
"NYA": "https://raw.githubusercontent.com/Millionsfrost/N.Y.A-NSFW-Modlist-Skyrim/main/modlists.json",
"Biblioklept": "https://raw.githubusercontent.com/Biblioklept/modlists/main/modlists.json"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every entry that comes before another entry, needs to end with a comma.

@@ -63,4 +62,6 @@
"VivaNewVegas": "https://raw.githubusercontent.com/Ungeziefi/VNV-Wabbajack/main/modlists.json",
"NYA": "https://raw.githubusercontent.com/Millionsfrost/N.Y.A-NSFW-Modlist-Skyrim/main/modlists.json",
"Biblioklept": "https://raw.githubusercontent.com/Biblioklept/modlists/main/modlists.json"
"WildCardFNV": "https://raw.githubusercontent.com/PsychoticNM/Wild-Card-FNV/main/modlists.json",
"WildCardTTW": "https://raw.githubusercontent.com/PsychoticNM/Wild-Card-TTW/main/modlists.json",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The final entry may not have a comma at the end.

@TDarkShadow TDarkShadow merged commit a2505be into wabbajack-tools:master May 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants