Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for crash when right clicking or doubler clicking browser url or window bar. #2599

Closed
wants to merge 4 commits into from

Conversation

JanuarySnow
Copy link
Contributor

@JanuarySnow JanuarySnow commented Jul 17, 2024

Fixes #2571

The current code ran Dragmove when any mousebutton event was fired, even right click, and Dragmove crashes when left button isnt held down when it is called.

Added just a guard to check left button is pressed before calling dragmove.

The crashing on double click couldve been caused by unlucky timing or threaded crap causing the function to be called when the button had already been released.

Confirmed crashing behavior prior to change, and confirmed no longer present afterwards

@tr4wzified
Copy link
Member

Closing this PR and pushed it to the main repo because otherwise the tests keep failing

@tr4wzified tr4wzified closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal exception on double clicking browser window.
2 participants