Fix for crash when right clicking or doubler clicking browser url or window bar. #2606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tested myself, seems fine 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2571
The current code ran Dragmove when any mousebutton event was fired, even right click, and Dragmove crashes when left button isnt held down when it is called.
Added just a guard to check left button is pressed before calling dragmove.
The crashing on double click couldve been caused by unlucky timing or threaded crap causing the function to be called when the button had already been released.
Confirmed crashing behavior prior to change, and confirmed no longer present afterwards
Credit goes to @JanuarySnow