Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for crash when right clicking or doubler clicking browser url or window bar. #2606

Merged
merged 4 commits into from
Aug 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
* This issue only affected Fallout 3, Fallout NV and Skyrim LE
* Added logging to determine which downloaded files cannot be hashed
* This could occur in the downloading phase when installing a modlist when there are broken/corrupted files in the downloads folder
* Fixed Wabbajack crashing when double-clicking the browser window titlebar or URL

#### Version - 3.7.0.0 - 6/21/2024
* Added Starfield support
Expand Down
6 changes: 4 additions & 2 deletions Wabbajack.App.Wpf/Views/BrowserWindow.xaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ public BrowserWindow(IServiceProvider serviceProvider)
{
InitializeComponent();


_disposable = new CompositeDisposable();
_serviceProvider = serviceProvider;
Browser = _serviceProvider.GetRequiredService<WebView2>();
Expand All @@ -43,7 +42,10 @@ public BrowserWindow(IServiceProvider serviceProvider)

private void UIElement_OnMouseDown(object sender, MouseButtonEventArgs e)
{
base.DragMove();
if (e.LeftButton == MouseButtonState.Pressed)
{
base.DragMove();
}
}

private void BrowserWindow_OnActivated(object sender, EventArgs e)
Expand Down
5 changes: 4 additions & 1 deletion Wabbajack.App.Wpf/Views/MainWindow.xaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,10 @@ private void Window_Closing(object sender, CancelEventArgs e)

private void UIElement_OnMouseDown(object sender, MouseButtonEventArgs e)
{
this.DragMove();
if (e.LeftButton == MouseButtonState.Pressed)
{
this.DragMove();
}
}

}
Expand Down
Loading