Allow storing more information in the downloaded archive metas so mods can be reinstalled and retain their meta-info #2614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stalled, to enable the mod to be remvoed then reinstalled from the archive and retain its metainfo like version etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when WJ writes a meta next to the downloaded Nexus archive, it just does modid, fileid and gamename
Thats basically all that is needed, but when it first reads the meta for that nexus download it stores a lot more info - version, description mod name etc.
The problem with the current behavior is that if you were to uninstall a mod in a downloaded WJ list, then reinstall it from Mo2s download pane, it would have no version or description information assigned to it as you no longer have a nexus meta, you have a shortened WJ meta.
But this info is parsed by Wabbajack, so ive enabled it to be written to the meta if it is present ( incase for some reason there is a manually constructed nexus meta by the author that dosnt have those fields)
Tested that it works - meta now has version, modname, and description fields, and can be reinstalled and retain this information.
I cant forsee this breaking anything else, and SME install went smoothly with this change, no other problems, but there is a nonzero chance someone will say "but Januarysnow, what about this edgecase!" and hereby I open myself up to that possibility.