-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Calibre's image actions to compress images in PRs #353
Comments
Hi @zerolab, I am new to contributing to wagtail, shall I proceed with this issue if not resolved already? |
Hey @udbhavsomani thank you for expressing your interest. Go for it. The rule is that unless the issue or a comment on the issue explicitly says not to, and there is no-one else who is working on it, then feel free to leave a note that you are working on it, or just open a draft PR. See https://dev.to/lb/ten-tasty-ingredients-for-a-delicious-pull-request-hgc for a lot of useful tips |
I’d like to propose we don’t do this via GitHub Actions, and instead do it manually. We can document the process to do it manually via something like Squoosh if we want, which should give the same image optimisation benefits without the drawbacks I foresee. The drawbacks are:
The possible benefits also seem way too small to me:
So – if we want to improve on image size, my preference would be to:
|
https://github.com/calibreapp/image-actions
Previously done manually (e.g. #285)
The text was updated successfully, but these errors were encountered: