Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#1082) ν¬λ ˆλ”§ λ‘œλ”© 인디케이터 λ™μž‘ 였λ₯˜ 이슈 ν•΄κ²° #1084

Merged
merged 1 commit into from
Aug 12, 2024
Merged

πŸ”€ :: (#1082) ν¬λ ˆλ”§ λ‘œλ”© 인디케이터 λ™μž‘ 였λ₯˜ 이슈 ν•΄κ²° #1084

merged 1 commit into from
Aug 12, 2024

Conversation

baekteun
Copy link
Member

πŸ’‘ λ°°κ²½ 및 κ°œμš”

  • ν¬λ ˆλ”§ λ‘œλ”© 인디케이터 λ™μž‘ 였λ₯˜ 이슈 ν•΄κ²°

Resolves: #1082

πŸ“ƒ μž‘μ—…λ‚΄μš©

  • ν¬λ ˆλ”§ λ‘œλ”© 인디케이터 λ™μž‘ 였λ₯˜ 이슈 ν•΄κ²°
  • λ§ˆμ§€λ§‰ νŽ˜μ΄μ§€μ— λ„λ‹¬ν–ˆλ‹€λŠ” flagλ₯Ό μ •ν•΄μ£Όμ—ˆμ–΄μš”.

βœ… PR 체크리슀트

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

@baekteun baekteun linked an issue Aug 12, 2024 that may be closed by this pull request
ν¬λ ˆλ”§ ν™”λ©΄ λ‘œλ”© 인디케이터 λ™μž‘ 였λ₯˜ #1082
Closed
@github-actions github-actions bot added the 0️⃣ Priority: Critical μš°μ„ μˆœμœ„ κΈ΄κΈ‰ label Aug 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 12, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions github-actions bot added the 🐞 Bug 버그 κ΄€λ ¨ label Aug 12, 2024
@github-actions GitHub Actions
Copy link

βœ… Assign μžλ™ 지정을 μ„±κ³΅ν–ˆμ–΄μš”!

@baekteun

@baekteun baekteun changed the base branch from develop to release/3.0.0 August 12, 2024 13:22
@baekteun baekteun merged commit 421b8c2 into release/3.0.0 Aug 12, 2024
5 checks passed
@baekteun baekteun deleted the 1082-credit-loading-indicator-error branch August 12, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KangTaeHoon KangTaeHoon KangTaeHoon approved these changes

@yongbeomkwak yongbeomkwak Awaiting requested review from yongbeomkwak yongbeomkwak is a code owner

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@youn9k youn9k Awaiting requested review from youn9k youn9k is a code owner

Assignees

@baekteun baekteun

Labels
0️⃣ Priority: Critical μš°μ„ μˆœμœ„ κΈ΄κΈ‰ 🐞 Bug 버그 κ΄€λ ¨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ν¬λ ˆλ”§ ν™”λ©΄ λ‘œλ”© 인디케이터 λ™μž‘ 였λ₯˜
2 participants
@baekteun @KangTaeHoon