Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#1112) develop์ด ์•„๋‹Œ ๋ธŒ๋žœ์น˜๋ฅผ ๋Œ€์ƒ์œผ๋กœ PR ๋จธ์ง€ ์‹œ ์—ฐ๊ด€๋œ ์ด์Šˆ ์ž๋™์œผ๋กœ close #1120

Merged

Conversation

baekteun
Copy link
Member

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

  • develop์ด ์•„๋‹Œ ๋ธŒ๋žœ์น˜๋ฅผ ๋Œ€์ƒ์œผ๋กœ PR ๋จธ์ง€ ์‹œ ์—ฐ๊ด€๋œ ์ด์Šˆ ์ž๋™์œผ๋กœ close

๋จธ์ง€ ๊ธฐ์ค€

PR ์„ค๋ช…์— 'Resolves: #{์ˆซ์ž}' ์—์„œ ์ˆซ์ž์— ํ•ด๋‹นํ•˜๋Š” Issue๊ฐ€ close๋ผ์š”. ๋งŒ์•ฝ ์•ˆ๋„ฃ์œผ๋ฉด ๋™์ž‘ํ•˜์ง€ ์•Š์œผ๋‹ˆ ์ธ์ง€ํ•ด์ฃผ์„ธ์šฉ @youn9k @KangTaeHoon @yongbeomkwak

Resolves: #1112

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • develop์ด ์•„๋‹Œ ๋ธŒ๋žœ์น˜๋ฅผ ๋Œ€์ƒ์œผ๋กœ PR ๋จธ์ง€ ์‹œ ์—ฐ๊ด€๋œ ์ด์Šˆ ์ž๋™์œผ๋กœ close

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

Copy link

โœ… ์ด์Šˆ์™€ PR์˜ Labels ๋™๊ธฐํ™”๋ฅผ ์„ฑ๊ณตํ–ˆ์–ด์š”!

Copy link

โœ… Assign ์ž๋™ ์ง€์ •์„ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@baekteun

Copy link
Member

@yongbeomkwak yongbeomkwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๊ฑธ js๋ž‘ docker๋กœ ํ•˜๋””๋‹ˆ .. ์ง„์งœ ๋Œ€๋ฐ•

@baekteun baekteun merged commit 9dc5169 into develop Aug 14, 2024
4 checks passed
@baekteun baekteun deleted the 1112-none-develop-branch-support-auto-close-linked-issue branch August 14, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2๏ธโƒฃ Priority: Medium ์šฐ์„ ์ˆœ์œ„ ์ค‘ โš™ Setting ๊ฐœ๋ฐœ ํ™˜๊ฒฝ ์„ธํŒ…
Projects
None yet
3 participants