Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#1148) ๊ฒ€์ƒ‰ ๊ฒฐ๊ณผ ๋กœ๋”ฉ ์ค‘ ํ•„ํ„ฐ๋‚˜ ์ •๋ ฌ์„ ๋ˆ„๋ฅผ ๋•Œ ์•ฑ์ด ํ„ฐ์ง€๋Š” ๋ฒ„๊ทธ #1151

Merged
merged 10 commits into from
Aug 16, 2024

Conversation

yongbeomkwak
Copy link
Member

@yongbeomkwak yongbeomkwak commented Aug 15, 2024

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

๊ฒ€์ƒ‰ ๊ฒฐ๊ณผ๊ฐ€ append๋˜๋ฉด์„œ ๊ฐ™์€ id๋ฅผ ๊ฐ–๋Š” ๋ฐ์ดํ„ฐ๋“ค์ด ์ค‘๋ณต๋˜๋Š” ๋ฒ„๊ทธ๊ฐ€ ์žˆ์Šต๋‹ˆ๋‹ค.

Resolves: #1148
Resolves: #1163

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

scrollPage๊ฐ€ 1์ผ ๋•Œ๋Š” ๋น„์–ด์žˆ๋Š” ๋ฐฐ์—ด๋กœ ๋ฐ์ดํ„ฐ๋ฅผ ์ฒ˜๋ฆฌํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@github-actions github-actions bot added 0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ ๊ธด๊ธ‰ ๐Ÿž Bug ๋ฒ„๊ทธ ๊ด€๋ จ labels Aug 15, 2024
Copy link

github-actions bot commented Aug 15, 2024

โœ… Successful finished SwiftLint

Copy link

โœ… Assign ์ž๋™ ์ง€์ •์„ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@yongbeomkwak

@baekteun baekteun marked this pull request as draft August 15, 2024 14:42
@yongbeomkwak yongbeomkwak marked this pull request as ready for review August 16, 2024 15:24
@yongbeomkwak yongbeomkwak merged commit 5e55d82 into release/3.0.0 Aug 16, 2024
3 checks passed
@yongbeomkwak yongbeomkwak deleted the 1148-fix-search-tab-during-loading branch August 16, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ ๊ธด๊ธ‰ ๐Ÿž Bug ๋ฒ„๊ทธ ๊ด€๋ จ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants