Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#1196) notiname λ³€κ²½ 및 마이 ν”Œλ¦¬ νŽΈμ§‘λͺ¨λ“œ 버그 ν•΄κ²° #1198

Merged
merged 2 commits into from
Aug 19, 2024
Merged

πŸ”€ :: (#1196) notiname λ³€κ²½ 및 마이 ν”Œλ¦¬ νŽΈμ§‘λͺ¨λ“œ 버그 ν•΄κ²° #1198

merged 2 commits into from
Aug 19, 2024

Conversation

yongbeomkwak
Copy link
Member

πŸ’‘ λ°°κ²½ 및 κ°œμš”

λ…Έν‹° 넀이밍이 λͺ…ν™•ν•˜μ§€ μ•Šμ•„ μˆ˜μ •ν•©λ‹ˆλ‹€.
λ§ˆμ΄ν”Œλ¦¬ νŽΈμ§‘ μ‹œμž‘ ν›„ λ‹€λ₯Έ 화면을 κ°”λ‹€μ˜€λ©΄ λ‚˜μ˜€λ©΄ μ™„λ£Œλ²„νŠΌμ΄ 사라지지 μ•Šμ•˜μŠ΅λ‹ˆλ‹€.

Resolves: #1196

πŸ“ƒ μž‘μ—…λ‚΄μš©

  • 노티이름 λ³€κ²½
  • μ™„λ£Œλ²„νŠΌ μˆ¨κΉ€ 처리

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

βœ… PR 체크리슀트

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 19, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions github-actions bot added the 1️⃣ Priority: High μš°μ„ μˆœμœ„ 상 label Aug 19, 2024
@github-actions GitHub Actions
Copy link

βœ… Assign μžλ™ 지정을 μ„±κ³΅ν–ˆμ–΄μš”!

@yongbeomkwak

@yongbeomkwak yongbeomkwak merged commit ef0482b into release/3.0.0 Aug 19, 2024
5 checks passed
@yongbeomkwak yongbeomkwak deleted the 1196-hide-fab-editing branch August 19, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KangTaeHoon KangTaeHoon KangTaeHoon approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@youn9k youn9k Awaiting requested review from youn9k youn9k is a code owner

@baekteun baekteun Awaiting requested review from baekteun baekteun is a code owner

Assignees

@yongbeomkwak yongbeomkwak

Labels
1️⃣ Priority: High μš°μ„ μˆœμœ„ 상
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yongbeomkwak @KangTaeHoon