Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#1238) μŒμ•… μž¬μƒ νƒ€μž… νŒμ—… Animation Spec λ³€κ²½ #1240

Merged
merged 1 commit into from
Aug 27, 2024
Merged

πŸ”€ :: (#1238) μŒμ•… μž¬μƒ νƒ€μž… νŒμ—… Animation Spec λ³€κ²½ #1240

merged 1 commit into from
Aug 27, 2024

Conversation

baekteun
Copy link
Member

@baekteun baekteun commented Aug 26, 2024 •
edited
Loading

πŸ’‘ λ°°κ²½ 및 κ°œμš”

μŒμ•… μž¬μƒ νƒ€μž… Animation Spec λ³€κ²½

Resolves: #1238

πŸ“ƒ μž‘μ—…λ‚΄μš©

μŒμ•… μž¬μƒ νƒ€μž… Animation Spec λ³€κ²½
λ…ΈμΆœ μ• λ‹ˆλ©”μ΄μ…˜ - 0.3초, curveEaseInOut, 80만큼 μ•„λž˜μ—μ„œλΆ€ν„° ν‘œμ‹œ μ‹œμž‘, Opacity 0 -> 1
νƒˆμΆœ μ• λ‹ˆλ©”μ΄μ…˜ - μ• λ‹ˆλ©”μ΄μ…˜ X

βœ… PR 체크리슀트

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

RPReplay_Final1724682457.MP4

@baekteun baekteun changed the title πŸ”€ :: (#1238) μŒμ•… μž¬μƒ νƒ€μž… Animation Spec λ³€κ²½ πŸ”€ :: (#1238) μŒμ•… μž¬μƒ νƒ€μž… νŒμ—… Animation Spec λ³€κ²½ Aug 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions github-actions bot added 1️⃣ Priority: High μš°μ„ μˆœμœ„ 상 ✨ Feature 피쳐 개발 labels Aug 26, 2024
@github-actions GitHub Actions
Copy link

βœ… μ΄μŠˆμ™€ PR의 Labels 동기화λ₯Ό μ„±κ³΅ν–ˆμ–΄μš”!

@baekteun baekteun marked this pull request as draft August 26, 2024 14:34
@baekteun baekteun force-pushed the 1238-youtube-song-play-type-modal-animation-spec branch from 2bc16a9 to a409490 Compare August 26, 2024 15:04
@baekteun baekteun marked this pull request as ready for review August 26, 2024 15:04
@baekteun baekteun force-pushed the 1238-youtube-song-play-type-modal-animation-spec branch from a409490 to 38d25b4 Compare August 26, 2024 15:20
Base automatically changed from 1237-new-log to release/3.0.0 August 26, 2024 23:07
@baekteun baekteun force-pushed the 1238-youtube-song-play-type-modal-animation-spec branch from 38d25b4 to 441c798 Compare August 26, 2024 23:08
@baekteun baekteun requested review from KangTaeHoon and removed request for KangTaeHoon August 26, 2024 23:10
@baekteun baekteun merged commit ea1f661 into release/3.0.0 Aug 27, 2024
3 checks passed
@baekteun baekteun deleted the 1238-youtube-song-play-type-modal-animation-spec branch August 27, 2024 02:22
@github-actions github-actions bot mentioned this pull request Aug 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@youn9k youn9k Awaiting requested review from youn9k youn9k is a code owner

@KangTaeHoon KangTaeHoon Awaiting requested review from KangTaeHoon KangTaeHoon is a code owner

Assignees

@baekteun baekteun

Labels
1️⃣ Priority: High μš°μ„ μˆœμœ„ 상 ✨ Feature 피쳐 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baekteun @yongbeomkwak