Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: (#1248) ๋‹จ์ผ๊ณก ์žฌ์ƒ ์‹œ ์ œ๋ชฉ์— Shorts๋ฅผ ์˜๋ฏธํ•˜๋Š” ํ…์ŠคํŠธ๊ฐ€ ํฌํ•จ๋˜์–ด์žˆ์„ ์‹œYoutube๋กœ ์žฌ์ƒ #1249

Merged
merged 2 commits into from
Aug 28, 2024
Merged

๐Ÿ”€ :: (#1248) ๋‹จ์ผ๊ณก ์žฌ์ƒ ์‹œ ์ œ๋ชฉ์— Shorts๋ฅผ ์˜๋ฏธํ•˜๋Š” ํ…์ŠคํŠธ๊ฐ€ ํฌํ•จ๋˜์–ด์žˆ์„ ์‹œYoutube๋กœ ์žฌ์ƒ #1249

merged 2 commits into from
Aug 28, 2024

Conversation

baekteun
Copy link
Member

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

๋‹จ์ผ๊ณก ์žฌ์ƒ ์‹œ ์ œ๋ชฉ์— Shorts๋ฅผ ์˜๋ฏธํ•˜๋Š” ํ…์ŠคํŠธ๊ฐ€ ํฌํ•จ๋˜์–ด์žˆ์„ ์‹œYoutube๋กœ ์žฌ์ƒ

Resolves: #1248

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

๋‹จ์ผ๊ณก ์žฌ์ƒ ์‹œ ์ œ๋ชฉ์— Shorts๋ฅผ ์˜๋ฏธํ•˜๋Š” ํ…์ŠคํŠธ๊ฐ€ ํฌํ•จ๋˜์–ด์žˆ์„ ์‹œYoutube๋กœ ์žฌ์ƒ

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 28, 2024 •
edited
Loading

โœ… Successful finished SwiftLint

@github-actions github-actions bot added 1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ ์ƒ โœจ Feature ํ”ผ์ณ ๊ฐœ๋ฐœ labels Aug 28, 2024
@github-actions GitHub Actions
Copy link

โœ… ์ด์Šˆ์™€ PR์˜ Labels ๋™๊ธฐํ™”๋ฅผ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@baekteun baekteun merged commit 916fcd2 into release/3.0.0 Aug 28, 2024
5 checks passed
@baekteun baekteun deleted the 1248-youtube-force-open-when-single-song-play branch August 28, 2024 13:45
@github-actions github-actions bot mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@KangTaeHoon KangTaeHoon Awaiting requested review from KangTaeHoon KangTaeHoon is a code owner

@youn9k youn9k Awaiting requested review from youn9k youn9k is a code owner

Assignees

@baekteun baekteun

Labels
1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ ์ƒ โœจ Feature ํ”ผ์ณ ๊ฐœ๋ฐœ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baekteun @yongbeomkwak