Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: (#1253) n๋“ฑ๋ถ„ ํŽ˜์ด์ง€ ์ปจํŠธ๋กค๋Ÿฌ ํ™”๋ฉด ํƒญ ๋ฒ„ํŠผ ์‚ฌ์ด๊ฐ„๊ฒฉ ์ œ๊ฑฐ #1254

Merged
merged 1 commit into from
Aug 29, 2024
Merged

๐Ÿ”€ :: (#1253) n๋“ฑ๋ถ„ ํŽ˜์ด์ง€ ์ปจํŠธ๋กค๋Ÿฌ ํ™”๋ฉด ํƒญ ๋ฒ„ํŠผ ์‚ฌ์ด๊ฐ„๊ฒฉ ์ œ๊ฑฐ #1254

merged 1 commit into from
Aug 29, 2024

Conversation

KangTaeHoon
Copy link
Contributor

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

์ตœ์‹ ์Œ์•… ํƒญ์—์„œ n๋“ฑ๋ถ„ ํƒญ์˜ ํ…์ŠคํŠธ๊ฐ€ ์งค๋ฆฌ๋Š” ํ˜„์ƒ ๋ฐœ๊ฒฌ

Resolves: #1253

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • bar.layout.contentMode = .fit ์œผ๋กœ ์‚ฌ์šฉ์ค‘์ธ ํ™”๋ฉด์˜ ๋ฒ„ํŠผ๊ฐ„๊ฒฉ 0์œผ๋กœ ์ˆ˜์ • (๋‚ด๋ถ€ ๊นŒ๋ณด๋‹ˆ ๋””ํดํŠธ ๊ฐ„๊ฒฉ์ด ์žˆ์—ˆ์Œ)

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

x

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

โœ… Successful finished SwiftLint

@github-actions github-actions bot added 0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ ๊ธด๊ธ‰ ๐Ÿž Bug ๋ฒ„๊ทธ ๊ด€๋ จ labels Aug 29, 2024
@github-actions GitHub Actions
Copy link

โœ… ์ด์Šˆ์™€ PR์˜ Labels ๋™๊ธฐํ™”๋ฅผ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@KangTaeHoon KangTaeHoon merged commit 451344c into release/3.0.0 Aug 29, 2024
5 checks passed
@KangTaeHoon KangTaeHoon deleted the 1253-fix-ui-divided-n-equal-scene branch August 29, 2024 16:12
@github-actions github-actions bot mentioned this pull request Aug 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@youn9k youn9k Awaiting requested review from youn9k youn9k is a code owner

@baekteun baekteun Awaiting requested review from baekteun baekteun is a code owner

Assignees

@KangTaeHoon KangTaeHoon

Labels
0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ ๊ธด๊ธ‰ ๐Ÿž Bug ๋ฒ„๊ทธ ๊ด€๋ จ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KangTaeHoon @yongbeomkwak