New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔀 :: (#1244) PDF 로드 실패 처리 #1256

Merged

KangTaeHoon merged 1 commit into release/3.0.0 from 1244-exception-process-pdf-contract-scene

Aug 30, 2024

Contributor

KangTaeHoon commented Aug 30, 2024

💡 배경 및 개요

이용약관, 개인정보 처리방침 로드실패에 대한 처리

Resolves: #1244

📃 작업내용

pdf파일 URL이 변경되는건지 뭔지 몰라서 그냥 둠
일부러 안 보여줄 필요까지는 없다고 봐요. 변경되면 URL바꾸고 아니면 놔두면 됩니다.

🙋‍♂️ 리뷰노트

x

✅ PR 체크리스트

이 작업으로 인해 변경이 필요한 문서가 변경되었나요? (e.g. XCConfig, 노션, README)
이 작업을 하고나서 공유해야할 팀원들에게 공유되었나요? (e.g. "API 개발 완료됐어요", "XCConfig 값 추가되었어요")
작업한 코드가 정상적으로 동작하나요?
Merge 대상 브랜치가 올바른가요?
PR과 관련 없는 작업이 있지는 않나요?

🎸 기타


          ✨ :: [#1244] PDF 로드 실패 처리

7984d47

KangTaeHoon requested review from yongbeomkwak, kimdaehee0824, youn9k and baekteun as code owners

August 30, 2024 02:33

github-actions bot added ⚡️ Simple 3️⃣ Priority: Low labels

github-actions bot commented Aug 30, 2024 •

edited

Loading

✅ Successful finished SwiftLint

github-actions bot assigned KangTaeHoon

github-actions bot commented Aug 30, 2024

✅ Assign 자동 지정을 성공했어요!

youn9k approved these changes

View reviewed changes

KangTaeHoon merged commit 883dc5c into release/3.0.0

5 checks passed

KangTaeHoon deleted the 1244-exception-process-pdf-contract-scene branch

August 30, 2024 04:30

github-actions bot mentioned this pull request

개인정보 처리방침 안보이도록 처리 #1244

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

youn9k youn9k approved these changes

yongbeomkwak Awaiting requested review from yongbeomkwak yongbeomkwak is a code owner

kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

baekteun Awaiting requested review from baekteun baekteun is a code owner

Labels

3️⃣ Priority: Low ⚡️ Simple