Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: (#1243) fix ๋ฏธ์„ค์น˜ ๋ฒ„ํŠผ ํ„ฐ์น˜ ์˜์—ญ ํ™•์žฅ #1267

Merged
merged 3 commits into from
Aug 31, 2024
Merged

๐Ÿ”€ :: (#1243) fix ๋ฏธ์„ค์น˜ ๋ฒ„ํŠผ ํ„ฐ์น˜ ์˜์—ญ ํ™•์žฅ #1267

merged 3 commits into from
Aug 31, 2024

Conversation

youn9k
Copy link
Member

@youn9k youn9k commented Aug 31, 2024

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

๋””์ž์ธ ์š”๊ตฌ์‚ฌํ•ญ ๋ณ€๊ฒฝ์— ๋”ฐ๋ผ ํ„ฐ์น˜ ์˜์—ญ์„ ํ™•์žฅํ•ฉ๋‹ˆ๋‹ค.

Resolves: #1243

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • ๋ฏธ์„ค์น˜ ๋ฒ„ํŠผ ๋ทฐ ๋ถ„๋ฆฌ

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

ํ™”๋ฉด ํ•˜์ด์–ด๋ผํ‚ค
simulator_screenshot_8E01ACE1-E3AD-4C6E-8691-5FA607F3F096 image

์ง€๊ธˆ๋ณด๋‹ˆ ๋””์ž์ธ์ด ๋งŽ์ด ๋ฐ”๋€Œ์—ˆ๋„ค์š”.. ๋‹ค์Œ PR์—์„œ ์ด์–ด์ง‘๋‹ˆ๋‹ค ๐Ÿ˜„

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 31, 2024 •
edited
Loading

โœ… Successful finished SwiftLint

@github-actions github-actions bot added โœจ Feature ํ”ผ์ณ ๊ฐœ๋ฐœ 3๏ธโƒฃ Priority: Low ์šฐ์„ ์ˆœ์œ„ ํ•˜ labels Aug 31, 2024
@github-actions GitHub Actions
Copy link

โœ… Assign ์ž๋™ ์ง€์ •์„ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@youn9k

@KangTaeHoon
Copy link
Contributor

์ด๋ฏธ์ง€๋งŒ ๋ฐ”๊ฟ”์„œ ๋ ๊ฒŒ ์•„๋‹Œ๊ฐ€์š”?

@youn9k
Copy link
Member Author

youn9k commented Aug 31, 2024

์ด๋ฏธ์ง€๋งŒ ๋ฐ”๊ฟ”์„œ ๋ ๊ฒŒ ์•„๋‹Œ๊ฐ€์š”?

๋„ค๋„น PR๋‚ด์šฉ ๋‹ค ์ž‘์„ฑํ•˜๊ณ  ํ”ผ๊ทธ๋งˆ๋ณด๋‹ˆ ๋ฐ”๊ฟ€๊ฒŒ ์กฐ๊ธˆ ์žˆ์–ด์„œ ๋ถ„๋ฆฌํ•ด์„œ ์˜ฌ๋ฆด๊ฒŒ์š”

@youn9k youn9k merged commit 2f44504 into release/3.0.0 Aug 31, 2024
2 checks passed
@youn9k youn9k deleted the 1243-fix-button-tap-area branch August 31, 2024 12:29
@github-actions github-actions bot mentioned this pull request Aug 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KangTaeHoon KangTaeHoon KangTaeHoon approved these changes

@yongbeomkwak yongbeomkwak Awaiting requested review from yongbeomkwak yongbeomkwak is a code owner

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@baekteun baekteun Awaiting requested review from baekteun baekteun is a code owner

Assignees

@youn9k youn9k

Labels
3๏ธโƒฃ Priority: Low ์šฐ์„ ์ˆœ์œ„ ํ•˜ โœจ Feature ํ”ผ์ณ ๊ฐœ๋ฐœ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youn9k @KangTaeHoon