Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#1277) λ―Έμ‚¬μš© ν™”λ©΄ 제거 (RequestVC) #1278

Merged
merged 1 commit into from
Sep 1, 2024
Merged

πŸ”€ :: (#1277) λ―Έμ‚¬μš© ν™”λ©΄ 제거 (RequestVC) #1278

merged 1 commit into from
Sep 1, 2024

Conversation

KangTaeHoon
Copy link
Contributor

πŸ’‘ λ°°κ²½ 및 κ°œμš”

  • λ ˆκ±°μ‹œ 제거

Resolves: #1277

πŸ“ƒ μž‘μ—…λ‚΄μš©

  • RequestVC, VM, SB 제거

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

x

βœ… PR 체크리슀트

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 1, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 1, 2024

βœ… μ΄μŠˆμ™€ PR의 Labels 동기화λ₯Ό μ„±κ³΅ν–ˆμ–΄μš”!

@github-actions github-actions bot added the 3️⃣ Priority: Low μš°μ„ μˆœμœ„ ν•˜ label Sep 1, 2024
@KangTaeHoon KangTaeHoon merged commit cebae3b into release/3.0.0 Sep 1, 2024
5 checks passed
@KangTaeHoon KangTaeHoon deleted the 1277-remove-unuse-scene-request branch September 1, 2024 10:45
@github-actions github-actions bot mentioned this pull request Sep 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baekteun baekteun baekteun approved these changes

@youn9k youn9k youn9k approved these changes

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

Assignees

@KangTaeHoon KangTaeHoon

Labels
3️⃣ Priority: Low μš°μ„ μˆœμœ„ ν•˜
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KangTaeHoon @yongbeomkwak @youn9k @baekteun