New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔀 :: (#1287) privacy, terms 주소 변경 #1288

Merged

yongbeomkwak merged 2 commits into release/3.0.0 from 1287-add-cdn-domain

Sep 3, 2024

Contributor

KangTaeHoon commented Sep 2, 2024 •

edited

Loading

💡 배경 및 개요

개인정보 처리방침, 서비스 이용약관 pdf 로드 주소가 변경 됨

Resolves: #1287

📃 작업내용

CDN 도메인 Secrets.xcconfig에 추가 (노션 업데이트)
미사용 도메인 경로 Secrets.xcconfig에서 제거 (노션 업데이트)
privacy, terms 주소 변경

🙋‍♂️ 리뷰노트

x

✅ PR 체크리스트

이 작업으로 인해 변경이 필요한 문서가 변경되었나요? (Secrets.xcconfig 노션 업데이트)
이 작업을 하고나서 공유해야할 팀원들에게 공유되었나요? (e.g. "API 개발 완료됐어요", "XCConfig 값 추가되었어요")
작업한 코드가 정상적으로 동작하나요?
Merge 대상 브랜치가 올바른가요?
PR과 관련 없는 작업이 있지는 않나요?

🎸 기타

KangTaeHoon added 2 commits

September 3, 2024 01:43


          ✨ :: [#1287] privacy, terms 주소 변경

921e2e3


          ✨ :: [#1287] 누락 된 QueriesSchemes 복구

454cc4b

KangTaeHoon requested review from yongbeomkwak, kimdaehee0824, youn9k and baekteun as code owners

September 2, 2024 16:52

github-actions bot added the 1️⃣ Priority: High label

github-actions bot commented Sep 2, 2024 •

edited

Loading

✅ Successful finished SwiftLint

github-actions bot commented Sep 2, 2024

✅ Assign 자동 지정을 성공했어요!

github-actions bot assigned KangTaeHoon

yongbeomkwak approved these changes

View reviewed changes

baekteun approved these changes

View reviewed changes

yongbeomkwak merged commit 2748993 into release/3.0.0

5 checks passed

yongbeomkwak deleted the 1287-add-cdn-domain branch

September 3, 2024 00:58

github-actions bot mentioned this pull request

privacy, terms 주소 변경 #1287

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

baekteun baekteun approved these changes

yongbeomkwak yongbeomkwak approved these changes

kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

youn9k Awaiting requested review from youn9k youn9k is a code owner

Labels

1️⃣ Priority: High