From 7c70d0caf57f2fac4465a97ba3d466cb72d837ac Mon Sep 17 00:00:00 2001 From: "pikagreen@nate.com" Date: Thu, 5 Sep 2024 01:39:00 +0900 Subject: [PATCH 1/2] =?UTF-8?q?=E2=9C=A8=20::=20[#1291]=20=ED=84=B0?= =?UTF-8?q?=EC=B9=98=20=EC=98=81=EC=97=AD=20=EB=B3=80=EA=B2=BD?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../Features/ArtistFeature/Resources/Artist.storyboard | 9 +++++++++ .../ArtistDetailHeaderViewController.swift | 4 +++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/Projects/Features/ArtistFeature/Resources/Artist.storyboard b/Projects/Features/ArtistFeature/Resources/Artist.storyboard index ddb2f0446..3b918801a 100644 --- a/Projects/Features/ArtistFeature/Resources/Artist.storyboard +++ b/Projects/Features/ArtistFeature/Resources/Artist.storyboard @@ -233,15 +233,23 @@ + + + + + @@ -277,6 +285,7 @@ + diff --git a/Projects/Features/ArtistFeature/Sources/ViewControllers/ArtistDetailHeaderViewController.swift b/Projects/Features/ArtistFeature/Sources/ViewControllers/ArtistDetailHeaderViewController.swift index 77b1491f7..66a812bf5 100644 --- a/Projects/Features/ArtistFeature/Sources/ViewControllers/ArtistDetailHeaderViewController.swift +++ b/Projects/Features/ArtistFeature/Sources/ViewControllers/ArtistDetailHeaderViewController.swift @@ -9,6 +9,7 @@ import Utility class ArtistDetailHeaderViewController: UIViewController, ViewControllerFromStoryBoard { @IBOutlet weak var artistImageView: UIImageView! @IBOutlet weak var descriptionView: UIView! + @IBOutlet weak var flipButton: UIButton! /// Description Front @IBOutlet weak var descriptionFrontView: UIView! @@ -138,7 +139,8 @@ private extension ArtistDetailHeaderViewController { func bind() { let mergeObservable = Observable.merge( descriptionFrontButton.rx.tap.map { _ in () }, - descriptionBackButton.rx.tap.map { _ in () } + descriptionBackButton.rx.tap.map { _ in () }, + flipButton.rx.tap.map { _ in () } ) mergeObservable From 9323fb6ecc46613f086b294dfe538f9d5a37a91a Mon Sep 17 00:00:00 2001 From: KTH Date: Thu, 5 Sep 2024 01:40:27 +0900 Subject: [PATCH 2/2] =?UTF-8?q?=E2=9C=A8=20::=20[#1291]=20=ED=84=B0?= =?UTF-8?q?=EC=B9=98=20=EC=98=81=EC=97=AD=20=EB=B3=80=EA=B2=BD=202t?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../ArtistDetailHeaderViewController.swift | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/Projects/Features/ArtistFeature/Sources/ViewControllers/ArtistDetailHeaderViewController.swift b/Projects/Features/ArtistFeature/Sources/ViewControllers/ArtistDetailHeaderViewController.swift index 66a812bf5..64fbae61c 100644 --- a/Projects/Features/ArtistFeature/Sources/ViewControllers/ArtistDetailHeaderViewController.swift +++ b/Projects/Features/ArtistFeature/Sources/ViewControllers/ArtistDetailHeaderViewController.swift @@ -137,13 +137,7 @@ extension ArtistDetailHeaderViewController { private extension ArtistDetailHeaderViewController { func bind() { - let mergeObservable = Observable.merge( - descriptionFrontButton.rx.tap.map { _ in () }, - descriptionBackButton.rx.tap.map { _ in () }, - flipButton.rx.tap.map { _ in () } - ) - - mergeObservable + flipButton.rx.tap .bind(with: self) { owner, _ in LogManager.analytics( ArtistAnalyticsLog.clickArtistDescriptionButton(artist: owner.model?.id ?? "")