New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔀 :: (#1293) 중복 닉네임 에러 캐치 등 #1294

Merged

KangTaeHoon merged 3 commits into develop from 1293-catch-error-nickname-modify

Sep 8, 2024

Contributor

KangTaeHoon commented Sep 7, 2024

💡 배경 및 개요

키워드, 중복 닉네임에 대한 처리 미흡

Resolves: #1293

📃 작업내용

'자' 텍스트 추가된 UI 수정: (n자/12 > n자/12자)
409 conflict 에러 캐치

🙋‍♂️ 리뷰노트

이제 develop으로 머지

✅ PR 체크리스트

이 작업으로 인해 변경이 필요한 문서가 변경되었나요? (e.g. XCConfig, 노션, README)
이 작업을 하고나서 공유해야할 팀원들에게 공유되었나요? (e.g. "API 개발 완료됐어요", "XCConfig 값 추가되었어요")
작업한 코드가 정상적으로 동작하나요?
Merge 대상 브랜치가 올바른가요?
PR과 관련 없는 작업이 있지는 않나요?

🎸 기타


          ✨ :: [#1293] 중복닉네임 에러 캐치

24c33d9

KangTaeHoon requested review from yongbeomkwak, kimdaehee0824, youn9k and baekteun as code owners

September 7, 2024 16:16

github-actions bot assigned KangTaeHoon

github-actions bot commented Sep 7, 2024 •

edited

Loading

✅ Successful finished SwiftLint

github-actions bot commented Sep 7, 2024

✅ 이슈와 PR의 Labels 동기화를 성공했어요!

github-actions bot added the 1️⃣ Priority: High label

KangTaeHoon and others added 2 commits

September 8, 2024 01:18


          Merge branch 'develop' into 1293-catch-error-nickname-modify

03f33ce


          ✨ :: [#1293] 문구 수정

c3d7d5b

youn9k approved these changes

View reviewed changes

KangTaeHoon merged commit 9d151b1 into develop

3 checks passed

KangTaeHoon deleted the 1293-catch-error-nickname-modify branch

September 8, 2024 06:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

youn9k youn9k approved these changes

yongbeomkwak Awaiting requested review from yongbeomkwak yongbeomkwak is a code owner

kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

baekteun Awaiting requested review from baekteun baekteun is a code owner

Labels

1️⃣ Priority: High