Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#1299) λΉˆν† ν° 미전솑 #1302

Merged
merged 2 commits into from
Sep 22, 2024
Merged

πŸ”€ :: (#1299) λΉˆν† ν° 미전솑 #1302

merged 2 commits into from
Sep 22, 2024

Conversation

baekteun
Copy link
Member

πŸ’‘ λ°°κ²½ 및 κ°œμš”

λ”°λ‘œ μ²˜λ¦¬ν•˜κΈ° μ–΄λ €μš΄ μƒνƒœλΌ κ·Έλƒ₯ μ•„μ˜ˆ ν†΅μ‹ ν• λ•Œ μ˜ˆμ™Έ μ²˜λ¦¬λ„λ‘ μœ λ„ν–ˆμ–΄μš”

Resolves: #1299

βœ… PR 체크리슀트

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@baekteun baekteun linked an issue Sep 22, 2024 that may be closed by this pull request
빈 토큰을 push ν† ν°μœΌλ‘œ μ „μ†‘ν•˜λŠ” 이슈 #1299
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 22, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions github-actions bot added the 🐞 Bug 버그 κ΄€λ ¨ label Sep 22, 2024
@github-actions GitHub Actions
Copy link

βœ… μ΄μŠˆμ™€ PR의 Labels 동기화λ₯Ό μ„±κ³΅ν–ˆμ–΄μš”!

@baekteun baekteun merged commit d1ec057 into develop Sep 22, 2024
3 checks passed
@baekteun baekteun deleted the 1299-empty-token branch September 22, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youn9k youn9k youn9k approved these changes

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@KangTaeHoon KangTaeHoon Awaiting requested review from KangTaeHoon KangTaeHoon is a code owner

Assignees

@baekteun baekteun

Labels
🐞 Bug 버그 κ΄€λ ¨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

빈 토큰을 push ν† ν°μœΌλ‘œ μ „μ†‘ν•˜λŠ” 이슈
3 participants
@baekteun @yongbeomkwak @youn9k