Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#1306) Long Press ํŽธ์ง‘๋ชจ๋“œ ์ง„์ž…์  ์ถ”๊ฐ€ #1307

Merged
merged 4 commits into from
Oct 12, 2024

Conversation

baekteun
Copy link
Member

@baekteun baekteun commented Oct 9, 2024

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

Long Press ํŽธ์ง‘๋ชจ๋“œ ์ง„์ž…์  ์ถ”๊ฐ€

Resolves: #1306

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

Long Press ํŽธ์ง‘๋ชจ๋“œ ์ง„์ž…์  ์ถ”๊ฐ€

  • ๋ณด๊ด€ํ•จ
  • ๋งˆ์ดํ”Œ๋ฆฌ
  • ์žฌ์ƒ๋ชฉ๋ก

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

cell select ๋ฐฉ์‹ ๋ณ€๊ฒฝํ–ˆ์–ด์š”. cell select ๋ฐฉ์‹์ด cell๋‚ด๋ถ€์— ๋ฒ„ํŠผ์œผ๋กœ ๊ฐ์‹ธ๋†“์•˜๋Š”๋ฐ, ์—ฌ๋Ÿฌ๋ชจ๋กœ ๋ณ€์ˆ˜๊ฐ€ ์ปค์„œ ๊ทธ๋ƒฅ ์™„์ „ํžˆ cell์—์„œ ํด๋ฆญ์ด๋ž‘ long press๊ฐ™์€ ํ–‰๋™ ์˜์กดํ•˜๊ฒŒ ํ•ด๋†จ์–ด์š”

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-09.at.20.49.56.mp4

Copy link

github-actions bot commented Oct 9, 2024

โœ… Successful finished SwiftLint

@github-actions github-actions bot added 1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ ์ƒ โœจ Feature ํ”ผ์ณ ๊ฐœ๋ฐœ labels Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

โœ… ์ด์Šˆ์™€ PR์˜ Labels ๋™๊ธฐํ™”๋ฅผ ์„ฑ๊ณตํ–ˆ์–ด์š”!

Copy link
Member

@yongbeomkwak yongbeomkwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค.

@baekteun baekteun merged commit e7a1146 into develop Oct 12, 2024
5 checks passed
@baekteun baekteun deleted the 1306-long-press-edit-mode branch October 12, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ ์ƒ โœจ Feature ํ”ผ์ณ ๊ฐœ๋ฐœ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long Press๋กœ ํŽธ์ง‘๋ชจ๋“œ ์ง„์ž…
2 participants