Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: [#1309] Long Press μ§„μž…μ μ˜ UXκ°€ 비정상적인 이슈 #1311

Merged
merged 5 commits into from
Oct 13, 2024
Merged

πŸ”€ :: [#1309] Long Press μ§„μž…μ μ˜ UXκ°€ 비정상적인 이슈 #1311

merged 5 commits into from
Oct 13, 2024

Conversation

baekteun
Copy link
Member

πŸ’‘ λ°°κ²½ 및 κ°œμš”

Long Press μ§„μž…μ μ˜ UXκ°€ 비정상적인 이슈 ν•΄κ²°

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-12.at.23.20.36.mp4
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-12.at.23.21.13.mp4

Resolves: #1309

πŸ“ƒ μž‘μ—…λ‚΄μš©

Long Press μ§„μž…μ μ˜ UXκ°€ 비정상적인 이슈 ν•΄κ²°

βœ… PR 체크리슀트

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@baekteun baekteun linked an issue Oct 12, 2024 that may be closed by this pull request
Long press νŽΈμ§‘λͺ¨λ“œ μ§„μž…μ˜ UXκ°€ λΉ„μ •μƒμ μž„ #1309
Closed
@baekteun baekteun changed the title Long Press μ§„μž…μ μ˜ UXκ°€ 비정상적인 이슈 πŸ”€ :: [#1309]Long Press μ§„μž…μ μ˜ UXκ°€ 비정상적인 이슈 Oct 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 12, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions GitHub Actions
Copy link

βœ… Assign μžλ™ 지정을 μ„±κ³΅ν–ˆμ–΄μš”!

@baekteun

@baekteun baekteun changed the title πŸ”€ :: [#1309]Long Press μ§„μž…μ μ˜ UXκ°€ 비정상적인 이슈 πŸ”€ :: [#1309] Long Press μ§„μž…μ μ˜ UXκ°€ 비정상적인 이슈 Oct 12, 2024
@baekteun baekteun added the 🐞 Bug 버그 κ΄€λ ¨ label Oct 12, 2024
@baekteun baekteun merged commit e8b9232 into develop Oct 13, 2024
4 of 5 checks passed
@baekteun baekteun deleted the 1309-long-press-edit-mode-ux branch October 13, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@KangTaeHoon KangTaeHoon Awaiting requested review from KangTaeHoon KangTaeHoon is a code owner

@youn9k youn9k Awaiting requested review from youn9k youn9k is a code owner

Assignees

@baekteun baekteun

Labels
🐞 Bug 버그 κ΄€λ ¨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Long press νŽΈμ§‘λͺ¨λ“œ μ§„μž…μ˜ UXκ°€ λΉ„μ •μƒμ μž„
2 participants
@baekteun @yongbeomkwak