Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ”€ :: (#1310) μž¬μƒλͺ©λ‘, λ‚˜μ˜ ν”Œλ¦¬ swipe delete κ΅¬ν˜„ #1318

Merged
merged 7 commits into from
Oct 25, 2024

Conversation

yongbeomkwak
Copy link
Member

πŸ’‘ λ°°κ²½ 및 κ°œμš”

쑰금 더 μ†μ‰¬μš΄ μ‚­μ œλ₯Ό 톡해 UXλ₯Ό ν–₯상 μ‹œν‚΅λ‹ˆλ‹€.

Resolves: #1310

πŸ“ƒ μž‘μ—…λ‚΄μš©

tableview Swipe delete μ˜΅μ…˜ μΆ”κ°€

  public func tableView(
        _ tableView: UITableView,
        trailingSwipeActionsConfigurationForRowAt indexPath: IndexPath
    ) -> UISwipeActionsConfiguration? {
        let deleteAction = UIContextualAction(style: .destructive, title: "μ‚­μ œ") { [weak self] action, _, completion in
            guard let self else { return }
            self.reactor?.action.onNext(.removeSwippedButtonDidTap(indexPath))
        }

        deleteAction.backgroundColor = DesignSystemAsset.PrimaryColorV2.increase.color

        let configuration = UISwipeActionsConfiguration(actions: [deleteAction])
        configuration.performsFirstActionWithFullSwipe = false

        return configuration
    }

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

βœ… PR 체크리슀트

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

Copy link

github-actions bot commented Oct 22, 2024

βœ… Successful finished SwiftLint

@github-actions github-actions bot added 1️⃣ Priority: High μš°μ„ μˆœμœ„ 상 ✨ Feature 피쳐 개발 labels Oct 22, 2024
Copy link

βœ… μ΄μŠˆμ™€ PR의 Labels 동기화λ₯Ό μ„±κ³΅ν–ˆμ–΄μš”!

@yongbeomkwak yongbeomkwak merged commit 32265c4 into develop Oct 25, 2024
3 checks passed
@yongbeomkwak yongbeomkwak deleted the implement-swipe-delete branch October 25, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1️⃣ Priority: High μš°μ„ μˆœμœ„ 상 ✨ Feature 피쳐 개발
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swipe Delete 지원
4 participants