New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔀 :: (#1317) 할로윈 스플래시 추가 #1319

Merged

KangTaeHoon merged 3 commits into develop from 1317-modify-splash-logo

Oct 24, 2024

Contributor

KangTaeHoon commented Oct 23, 2024 •

edited

Loading

💡 배경 및 개요

할로윈 스플래쉬 추가

Resolves: #1317

📃 작업내용

isSpecialLogo Flag로 변경하던 스플래쉬 로고에 분기 추가 (10월 - 할로윈, 12월 - xmas, 나머지 - 기본)
Lottie SDK 업데이트 (4.4.3 > 4.5.0)

🙋‍♂️ 리뷰노트

로티 비정상

✅ PR 체크리스트

이 작업으로 인해 변경이 필요한 문서가 변경되었나요? (e.g. XCConfig, 노션, README)
이 작업을 하고나서 공유해야할 팀원들에게 공유되었나요? (e.g. "API 개발 완료됐어요", "XCConfig 값 추가되었어요")
작업한 코드가 정상적으로 동작하나요?
Merge 대상 브랜치가 올바른가요?
PR과 관련 없는 작업이 있지는 않나요?

🎸 기타

KangTaeHoon added 3 commits

October 22, 2024 18:08


          ✨ :: [#1317] 스플래쉬 로고 월 별 분기 로직 작성

3aa4df5


          ✨ :: [#1317] 스플래쉬 로고 월 별 분기 로직 작성 2t

be62d2a


          ✨ :: [#1317] 스플래쉬 로고 3t

aeee48c

KangTaeHoon requested review from yongbeomkwak, kimdaehee0824, youn9k and baekteun as code owners

October 23, 2024 02:42

github-actions bot assigned KangTaeHoon

github-actions bot commented Oct 23, 2024 •

edited

Loading

✅ Successful finished SwiftLint

github-actions bot added 1️⃣ Priority: High ⚡️ Simple labels

github-actions bot commented Oct 23, 2024

✅ 이슈와 PR의 Labels 동기화를 성공했어요!

yongbeomkwak approved these changes

View reviewed changes

KangTaeHoon merged commit 4008c69 into develop

5 checks passed

KangTaeHoon deleted the 1317-modify-splash-logo branch

October 24, 2024 11:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yongbeomkwak yongbeomkwak approved these changes

kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

youn9k Awaiting requested review from youn9k youn9k is a code owner

baekteun Awaiting requested review from baekteun baekteun is a code owner

Labels

1️⃣ Priority: High ⚡️ Simple