Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#1320) ๊ธฐ๊ฐ„์— ๋งž๋Š” ์•ฑ ์•„์ด์ฝ˜ ์ž๋™ ๋ณ€๊ฒฝ #1321

Merged
merged 4 commits into from
Oct 26, 2024

Conversation

yongbeomkwak
Copy link
Member

@yongbeomkwak yongbeomkwak commented Oct 26, 2024

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

์‹ฌ์‚ฌ ํ•„์š”์—†์ด ์„œ๋ฒ„์—์„œ ๋ณด๋‚ด์ฃผ๋Š” ํ”Œ๋ž˜๊ทธ์— ๋”ฐ๋ฅธ ์•Œ๋งž์€ ์•ฑ ์•„์ด์ฝ˜์œผ๋กœ ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•ฉ๋‹ˆ๋‹ค.

Resolves: #1320

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • Asset์— ์•ฑ ์•„์ด์ฝ˜ ์ถ”๊ฐ€
  • target์˜ build setting Alternate App Icon Sets์— ์•ฑ ์•„์ด์ฝ˜ ์—์…‹ ๋„ฃ๊ธฐ
  • ์•ฑ ์•„์ด์ฝ˜ ๋ณ€๊ฒฝ ์ฝ”๋“œ๋ฅผ ํ†ตํ•ด ๋ณ€๊ฒฝ
แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2024-10-26 แ„‹แ…ฉแ„’แ…ฎ 4 29 16 แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2024-10-26 แ„‹แ…ฉแ„’แ…ฎ 4 28 38
enum SplashLogoType: String {
    case usual = "Splash_Logo_Main"
    case halloween = "Splash_Logo_Halloween"
    case xmas = "Splash_Logo_Xmas"

    var icon: String? {
        switch self {
        case .usual:
            return nil
        case .halloween:
            return "HalloweenAppIcon"
        case .xmas:
            return "XmasAppIcon"
        }
    }
}

func changeAppIcon(_ type: SplashLogoType) {
    guard UIApplication.shared.alternateIconName != type.icon else {
        return
    }

    UIApplication.shared.setAlternateIconName(type.icon)
}

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@github-actions github-actions bot added 1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ ์ƒ โšก๏ธ Performance ์„ฑ๋Šฅ ๊ฐœ์„  labels Oct 26, 2024
Copy link

github-actions bot commented Oct 26, 2024

โœ… Successful finished SwiftLint

Copy link

โœ… Assign ์ž๋™ ์ง€์ •์„ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@yongbeomkwak

Copy link
Member

@baekteun baekteun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Project.swift์— build settings ์ˆ˜์ •ํ•˜์…”์•ผํ• ๊ฑฐ๊ฐ™์•„์š”

@yongbeomkwak yongbeomkwak merged commit ec678d7 into release/3.1.0 Oct 26, 2024
3 checks passed
@yongbeomkwak yongbeomkwak deleted the apply-multi-special-icons branch October 26, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ ์ƒ โšก๏ธ Performance ์„ฑ๋Šฅ ๊ฐœ์„ 
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants