Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#1316) μŒμ•… μƒμ„Έμ—μ„œ μ•„ν‹°μŠ€νŠΈ 이름 클릭 μ‹œ ν¬λ ˆλ”§ ν˜Ήμ€ μ•„ν‹°μŠ€νŠΈ μƒμ„Έλ‘œ 이동 #1322

Merged
merged 6 commits into from
Nov 1, 2024
Merged

πŸ”€ :: (#1316) μŒμ•… μƒμ„Έμ—μ„œ μ•„ν‹°μŠ€νŠΈ 이름 클릭 μ‹œ ν¬λ ˆλ”§ ν˜Ήμ€ μ•„ν‹°μŠ€νŠΈ μƒμ„Έλ‘œ 이동 #1322

merged 6 commits into from
Nov 1, 2024

Conversation

baekteun
Copy link
Member

πŸ’‘ λ°°κ²½ 및 κ°œμš”

μŒμ•… μƒμ„Έμ—μ„œ μ•„ν‹°μŠ€νŠΈ 이름 클릭 μ‹œ ν¬λ ˆλ”§ ν˜Ήμ€ μ•„ν‹°μŠ€νŠΈ μƒμ„Έλ‘œ 이동

Resolves: #1316

πŸ“ƒ μž‘μ—…λ‚΄μš©

μŒμ•… μƒμ„Έμ—μ„œ μ•„ν‹°μŠ€νŠΈ 이름 클릭 μ‹œ ν¬λ ˆλ”§ ν˜Ήμ€ μ•„ν‹°μŠ€νŠΈ μƒμ„Έλ‘œ 이동

βœ… PR 체크리슀트

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@baekteun baekteun linked an issue Oct 28, 2024 that may be closed by this pull request
λ…Έλž˜ μƒμ„Έμ—μ„œ μ•„ν‹°μŠ€νŠΈ 클릭 μ‹œ μ•„ν‹°μŠ€νŠΈ μƒμ„Έλ‘œ 이동 #1316
Closed
@github-actions github-actions bot added the ✨ Feature 피쳐 개발 label Oct 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 28, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions GitHub Actions
Copy link

βœ… Assign μžλ™ 지정을 μ„±κ³΅ν–ˆμ–΄μš”!

@baekteun

@baekteun baekteun requested a review from KangTaeHoon October 29, 2024 12:12
@baekteun baekteun merged commit 8f3200a into develop Nov 1, 2024
3 checks passed
@baekteun baekteun deleted the 1316-music-detail-artist-or-credit branch November 1, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@KangTaeHoon KangTaeHoon KangTaeHoon approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@youn9k youn9k Awaiting requested review from youn9k youn9k is a code owner

Assignees

@baekteun baekteun

Labels
✨ Feature 피쳐 개발
Projects
None yet
Milestone
No milestone
3 participants
@baekteun @KangTaeHoon @yongbeomkwak