Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#1323) ๋งˆ์ด ํ”Œ๋ฆฌ ์žฌ์ƒ ์‹œ ํ”Œ๋ฆฌ ์ œ๋ชฉ์ด '์™ํƒ€๋ฒ„์Šค ๋ฎค์ง'์œผ๋กœ ๋…ธ์ถœ๋จ #1324

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

baekteun
Copy link
Member

@baekteun baekteun commented Nov 1, 2024

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

๋งˆ์ด ํ”Œ๋ฆฌ ์žฌ์ƒ ์‹œ ํ”Œ๋ฆฌ ์ œ๋ชฉ์ด '์™ํƒ€๋ฒ„์Šค ๋ฎค์ง'์œผ๋กœ ๋…ธ์ถœ๋จ

Resolves: #1323

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

๋งˆ์ด ํ”Œ๋ฆฌ ์žฌ์ƒ ์‹œ ํ”Œ๋ฆฌ ์ œ๋ชฉ์ด '์™ํƒ€๋ฒ„์Šค ๋ฎค์ง'์œผ๋กœ ๋…ธ์ถœ๋˜๋Š” ์ด์Šˆ ํ•ด๊ฒฐ

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

Copy link

github-actions bot commented Nov 1, 2024

โœ… Successful finished SwiftLint

Copy link

github-actions bot commented Nov 1, 2024

โœ… Assign ์ž๋™ ์ง€์ •์„ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@baekteun

@baekteun baekteun merged commit a5929b8 into develop Nov 2, 2024
5 checks passed
@baekteun baekteun deleted the 1323-my-playlist-name-is-diffrenct branch November 2, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ ์ƒ ๐Ÿž Bug ๋ฒ„๊ทธ ๊ด€๋ จ
Projects
None yet
3 participants