Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#1325) μ΅œμ‹ μŒμ•… > νƒ­ 넀이밍 λ³€κ²½ #1326

Merged
merged 1 commit into from
Nov 21, 2024
Merged

πŸ”€ :: (#1325) μ΅œμ‹ μŒμ•… > νƒ­ 넀이밍 λ³€κ²½ #1326

merged 1 commit into from
Nov 21, 2024

Conversation

KangTaeHoon
Copy link
Contributor

πŸ’‘ λ°°κ²½ 및 κ°œμš”

μ΅œμ‹ μŒμ•… > νƒ­ 넀이밍 λ³€κ²½

Resolves: #1325

πŸ“ƒ μž‘μ—…λ‚΄μš©

κ³ λ©€ > ν΄λž˜μ‹

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

x

βœ… PR 체크리슀트

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@github-actions github-actions bot added 0️⃣ Priority: Critical μš°μ„ μˆœμœ„ κΈ΄κΈ‰ ⚑️ Simple κ°„λ‹¨ν•œ 변경사항 labels Nov 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions GitHub Actions
Copy link

βœ… Assign μžλ™ 지정을 μ„±κ³΅ν–ˆμ–΄μš”!

@KangTaeHoon

@KangTaeHoon KangTaeHoon merged commit 2a58c28 into develop Nov 21, 2024
5 checks passed
@KangTaeHoon KangTaeHoon deleted the 1325-change-tab-name-in-newsongs branch November 21, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baekteun baekteun baekteun approved these changes

@youn9k youn9k youn9k approved these changes

@yongbeomkwak yongbeomkwak Awaiting requested review from yongbeomkwak yongbeomkwak is a code owner

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

Assignees

@KangTaeHoon KangTaeHoon

Labels
0️⃣ Priority: Critical μš°μ„ μˆœμœ„ κΈ΄κΈ‰ ⚑️ Simple κ°„λ‹¨ν•œ 변경사항
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

μ΅œμ‹ μŒμ•… > νƒ­ 넀이밍 λ³€κ²½
3 participants
@KangTaeHoon @youn9k @baekteun