Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#1328) μ˜€ν”ˆμ†ŒμŠ€ λΌμ΄μ„ΌμŠ€ νŽ˜μ΄μ§€ 데이터가 λ…ΈμΆœλ˜μ§€ μ•ŠμŒ #1329

Merged
merged 2 commits into from
Dec 8, 2024
Merged

πŸ”€ :: (#1328) μ˜€ν”ˆμ†ŒμŠ€ λΌμ΄μ„ΌμŠ€ νŽ˜μ΄μ§€ 데이터가 λ…ΈμΆœλ˜μ§€ μ•ŠμŒ #1329

merged 2 commits into from
Dec 8, 2024

Conversation

baekteun
Copy link
Member

@baekteun baekteun commented Dec 8, 2024

πŸ’‘ λ°°κ²½ 및 κ°œμš”

μ˜€ν”ˆ μ†ŒμŠ€ λΌμ΄μ„ΌμŠ€ ViewModelμ—μ„œ binding을 ν•˜μ§€ μ•Šμ•˜μŒ

Resolves: #1328

πŸ“ƒ μž‘μ—…λ‚΄μš©

μ˜€ν”ˆ μ†ŒμŠ€ λΌμ΄μ„ΌμŠ€ ViewModel binding

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

βœ… PR 체크리슀트

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@github-actions github-actions bot added 0️⃣ Priority: Critical μš°μ„ μˆœμœ„ κΈ΄κΈ‰ 🐞 Bug 버그 κ΄€λ ¨ labels Dec 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2024

βœ… Assign μžλ™ 지정을 μ„±κ³΅ν–ˆμ–΄μš”!

@baekteun

@baekteun baekteun merged commit 0d6b3bf into release/3.2.2 Dec 8, 2024
5 checks passed
@baekteun baekteun deleted the 1328-open-source-license-data-is-empty branch December 8, 2024 08:51
@github-actions github-actions bot mentioned this pull request Dec 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@KangTaeHoon KangTaeHoon KangTaeHoon approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@youn9k youn9k Awaiting requested review from youn9k youn9k is a code owner

Assignees

@baekteun baekteun

Labels
0️⃣ Priority: Critical μš°μ„ μˆœμœ„ κΈ΄κΈ‰ 🐞 Bug 버그 κ΄€λ ¨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baekteun @KangTaeHoon @yongbeomkwak