Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#1330) FAQ numberOfLines๊ฐ€ ์ ์šฉ๋˜์ง€ ์•Š๋Š” ์ด์Šˆ ํ•ด๊ฒฐ #1331

Merged
merged 6 commits into from
Dec 8, 2024

Conversation

baekteun
Copy link
Member

@baekteun baekteun commented Dec 8, 2024

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

FAQ numberOfLines๊ฐ€ ์ ์šฉ๋˜์ง€ ์•Š๋Š” ์ด์Šˆ ํ•ด๊ฒฐ
MainActor ๋ณด์žฅ์„ ํ•ด์ค๋‹ˆ๋‹ค.

Resolves: #1330

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@github-actions github-actions bot added 0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ ๊ธด๊ธ‰ ๐Ÿž Bug ๋ฒ„๊ทธ ๊ด€๋ จ labels Dec 8, 2024
Copy link

github-actions bot commented Dec 8, 2024

โœ… Successful finished SwiftLint

Copy link

github-actions bot commented Dec 8, 2024

โœ… Assign ์ž๋™ ์ง€์ •์„ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@baekteun

@baekteun baekteun force-pushed the 1330-faq-numberoflines branch from 1e03c1a to c0c29bd Compare December 8, 2024 05:37
Base automatically changed from 1328-open-source-license-data-is-empty to release/3.2.2 December 8, 2024 08:51
@baekteun baekteun merged commit ec36407 into release/3.2.2 Dec 8, 2024
3 checks passed
@baekteun baekteun deleted the 1330-faq-numberoflines branch December 8, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ ๊ธด๊ธ‰ ๐Ÿž Bug ๋ฒ„๊ทธ ๊ด€๋ จ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants