🔀 :: (#458) Artist화면의 상태관리 객체 viewModel -> Reactor 전환 #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baekteun
requested review from
yongbeomkwak,
kimdaehee0824,
KangTaeHoon and
youn9k
as code owners
✅ Successful finished SwiftLint |
✅ 이슈와 PR의 Labels 동기화를 성공했어요! |
5 tasks
baekteun
force-pushed
the
457-add-reactorkit-dependency
branch
from
665ea81 to
569201e
Compare
baekteun
force-pushed
the
458-artist-screen-viewmodel-to-reactorkit
branch
from
4624868 to
89b8839
Compare
kimdaehee0824
approved these changes
Mar 11, 2024
Projects/Features/ArtistFeature/Sources/ViewControllers/ArtistViewController.swift
Show resolved
Hide resolved
Projects/Features/ArtistFeature/Sources/ViewControllers/ArtistViewController.swift
Show resolved
Hide resolved
baekteun
force-pushed
the
457-add-reactorkit-dependency
branch
from
569201e to
6f493c5
Compare
KangTaeHoon
approved these changes
Mar 11, 2024
Projects/Features/ArtistFeature/Sources/ViewControllers/ArtistViewController.swift
Show resolved
Hide resolved
baekteun
force-pushed
the
457-add-reactorkit-dependency
branch
from
6f493c5 to
375778f
Compare
yongbeomkwak
approved these changes
Mar 11, 2024
baekteun
force-pushed
the
457-add-reactorkit-dependency
branch
from
375778f to
bfd4df5
Compare
baekteun
force-pushed
the
458-artist-screen-viewmodel-to-reactorkit
branch
from
89b8839 to
ea327d4
Compare
baekteun
force-pushed
the
458-artist-screen-viewmodel-to-reactorkit
branch
from
ea327d4 to
c04a966
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 배경 및 개요
Artist 화면의 상태를 관리하는 객체를 viewModel에서 Reactor로 전환했어요.
Resolves: #458
📃 작업내용
🙋♂️ 리뷰노트
이 PR에서는 ArtistViewModel을 제거하지 않고, deprecated처리만 해요.
✅ PR 체크리스트
XCConfig,노션,README)"API 개발 완료됐어요","XCConfig 값 추가되었어요")