🔀 :: (#458) ArtistReactor Unit Test 작성 #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baekteun
requested review from
yongbeomkwak,
kimdaehee0824,
KangTaeHoon and
youn9k
as code owners
✅ Successful finished SwiftLint |
✅ Assign 자동 지정을 성공했어요! |
baekteun
changed the title
|
퀵 도입 고려해봐도 좋은 것 같네요 |
kimdaehee0824
approved these changes
Mar 11, 2024
| sut = nil | ||
| } | ||
|
|
||
| func test_when_viewDidLoad_action_and_artist_count_is_1_then_append_hidden_item() { |
There was a problem hiding this comment.
확실히 많이 기네요 ㅎㅎ....
아니면 테스트 함수만큼은 한글 네이밍을 해보는 건 어떨까요?
There was a problem hiding this comment.
테스트에 필요하다고 생각하는 라이브러리들 고민한번 해주시고 다음 테스트 작성 때 저도 따라 가겠습니다.
yongbeomkwak
approved these changes
Mar 11, 2024
baekteun
force-pushed
the
458-artist-screen-viewmodel-to-reactorkit
branch
from
89b8839 to
ea327d4
Compare
baekteun
force-pushed
the
458-artist-reactor-test
branch
from
27c7d94 to
17cde22
Compare
baekteun
force-pushed
the
458-artist-screen-viewmodel-to-reactorkit
branch
from
ea327d4 to
c04a966
Compare
baekteun
force-pushed
the
458-artist-reactor-test
branch
from
17cde22 to
51f1c66
Compare
Base automatically changed from
458-artist-screen-viewmodel-to-reactorkit
to
develop
March 12, 2024 09:54
baekteun
force-pushed
the
458-artist-reactor-test
branch
from
51f1c66 to
3e8c8ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 배경 및 개요
Artist화면의 Reactor의 Unit Test를 작성해요
Resolves: #458
📃 작업내용
🙋♂️ 리뷰노트
Quick이 없다보니 테스트의 이름이 다소 길어지네요 ㅠㅠ
주석으로 Given, When, Then을 구분해놨으니 test_viewDidLoad() 로만 작명할까요? 혹은 지금처럼 액션, when, then 에 따라 결과도 나오는 이름으로(현재방식)으로 작명할까요?
✅ PR 체크리스트
XCConfig,노션,README)"API 개발 완료됐어요","XCConfig 값 추가되었어요")