Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#474) SwiftFormat λŒ€μƒμ— NeedleGenerated 파일 μ œμ™Έ #475

Merged
merged 1 commit into from
Mar 13, 2024
Merged

πŸ”€ :: (#474) SwiftFormat λŒ€μƒμ— NeedleGenerated 파일 μ œμ™Έ #475

merged 1 commit into from
Mar 13, 2024

Conversation

baekteun
Copy link
Member

πŸ’‘ λ°°κ²½ 및 κ°œμš”

format μžλ™ν™” κΈ°λŠ₯이 μžˆλŠ”λ° 이 μΉœκ΅¬κ°€ λŒμ•„κ°ˆλ•Œλ§ˆλ‹€ NeedleGenerated.swift (μžλ™μƒμ„± 파일) 도 ν¬λ§€νŒ…μ΄ λ˜λ‹€λ³΄λ‹ˆ λΆˆν•„μš”ν•˜κ²Œ λ³€κ²½λ˜λŠ” μ½”λ“œκ°€ λ§Žμ•„μ Έμš”!

Resolves: #474

πŸ“ƒ μž‘μ—…λ‚΄μš©

.swiftformat 파일 exclude λŒ€μƒμ— '**/NeedleGenerated.swift' μΆ”κ°€

βœ… PR 체크리슀트

ν…œν”Œλ¦Ώ 체크리슀트 말고도 μΆ”κ°€μ μœΌλ‘œ ν•„μš”ν•œ μ²΄ν¬λ¦¬μŠ€νŠΈλŠ” μΆ”κ°€ν•΄μ£Όμ„Έμš”!

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

@baekteun baekteun linked an issue Mar 13, 2024 that may be closed by this pull request
SwiftFormat λŒ€μƒμ— NeedleGenerate.swift 파일 μ œμ™Έ #474
Closed
@github-actions GitHub Actions
Copy link

βœ… Assign μžλ™ 지정을 μ„±κ³΅ν–ˆμ–΄μš”!

@baekteun

@github-actions github-actions bot added ⚑️ Simple κ°„λ‹¨ν•œ 변경사항 βš™ Setting 개발 ν™˜κ²½ μ„ΈνŒ… labels Mar 13, 2024
@github-actions GitHub Actions
Copy link

βœ… μ΄μŠˆμ™€ PR의 Labels 동기화λ₯Ό μ„±κ³΅ν–ˆμ–΄μš”!

@baekteun baekteun merged commit fb2ea37 into develop Mar 13, 2024
4 checks passed
@baekteun baekteun deleted the 474-swiftformat-target-needlegenerateswift-exclude branch March 13, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@KangTaeHoon KangTaeHoon KangTaeHoon approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@youn9k youn9k Awaiting requested review from youn9k youn9k is a code owner

Assignees

@baekteun baekteun

Labels
βš™ Setting 개발 ν™˜κ²½ μ„ΈνŒ… ⚑️ Simple κ°„λ‹¨ν•œ 변경사항
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SwiftFormat λŒ€μƒμ— NeedleGenerate.swift 파일 μ œμ™Έ
3 participants
@baekteun @KangTaeHoon @yongbeomkwak