๐ :: (#484) Common Feature ๋ถ๋ฆฌ #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Common > Home
Common > MainTab
Common > Storage
BaseFeature๋ก ํตํฉ
PlayState
-import BaseFeature
yongbeomkwak
requested review from
kimdaehee0824,
KangTaeHoon,
youn9k and
baekteun
as code owners
โ Successful finished SwiftLint |
โ Assign ์๋ ์ง์ ์ ์ฑ๊ณตํ์ด์! |
baekteun
reviewed
Apr 16, 2024
Comment on lines
23
to
27
| var playListDetailComponent: PlayListDetailComponent { | ||
| var playlistFactory: any PlaylistFactory { | ||
| PlayListDetailComponent(parent: self) |
There was a problem hiding this comment.
์๊ฑฐ ํน์ ์ Detail์ด ๋ผ์ด์ง๊ฑฐ์์?
There was a problem hiding this comment.
ํจ์ฒ ์์ฒด๊ฐ PlaylistFeature๋ผ ๊ตณ์ด Detail์ ๋บ์ด์.
There was a problem hiding this comment.
์ฌ์๋ชฉ๋ก ํ๋ฉด๋์๋๋ฐ ์ด๋ฆ ์ค๋ณต์ผ๋ฏ
There was a problem hiding this comment.
ํ .. ๊ฑฐ๊ธฐ๋ฅผ ์กฐ๊ธ ๋ฐ๊พธ๋๊ฒ ๋ซ์ง ์์๊น์
์ ๊ฐ ๊ฑด๋๋ฆฐ์ชฝ์ด ๋ ๋ง์ด ๊ฑด๋ค์ด์ง๋๋ฐ ..
There was a problem hiding this comment.
์ปดํฌ๋ํธ๋ ๋ํ ์ผ์ด๊ณ ํฉํ ๋ฆฌ๋ ๋ํ ์ผ์์ด์ ์ผ๊ด์ฑ์ ์์ด๋ณด์ ๋๋ค.
There was a problem hiding this comment.
ํ .. ๊ทธ๋ฌ๋ฉด ์ ๊ฐ ๋ณ๊ฒฝํด๋ณผ๊ป์ฌ
baekteun
changed the title
KangTaeHoon
approved these changes
Apr 16, 2024
youn9k
approved these changes
Apr 16, 2024
baekteun
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐ์
๋ผ์ง ๊ฐ์ด ๋ถํ์๋ Common ํจ์ฒ๋ฅผ ํด์ฒด ํฉ๋๋ค.
Resolves: #484 #490
๐ ์์ ๋ด์ฉ
๐โโ๏ธ ๋ฆฌ๋ทฐ๋ ธํธ
โ PR ์ฒดํฌ๋ฆฌ์คํธ
XCConfig,๋ ธ์ ,README)"API ๊ฐ๋ฐ ์๋ฃ๋์ด์","XCConfig ๊ฐ ์ถ๊ฐ๋์์ด์")๐ธ ๊ธฐํ
ํ ๋์ค๋ค์ .. ใ ใ