Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#494) μ•„ν‹°μŠ€νŠΈ νŽ˜μ΄μ§€ λ¦¬νŒ©ν† λ§ #504

Merged
merged 6 commits into from
Apr 26, 2024
Merged

πŸ”€ :: (#494) μ•„ν‹°μŠ€νŠΈ νŽ˜μ΄μ§€ λ¦¬νŒ©ν† λ§ #504

merged 6 commits into from
Apr 26, 2024

Conversation

KangTaeHoon
Copy link
Contributor

@KangTaeHoon KangTaeHoon commented Apr 23, 2024 •
edited
Loading

πŸ’‘ λ°°κ²½ 및 κ°œμš”

v3.0 λ“€μ–΄κ°€κΈ° μ „ ꡬ더기 μ½”λ“œλ₯Ό μ œκ±°ν–ˆμ–΄μš”.

Resolves: #494

πŸ“ƒ μž‘μ—…λ‚΄μš©

  • μ•„ν‹°μŠ€νŠΈ λ¦¬μŠ€νŠΈκ°€ 1개만 μ‘΄μž¬ν•˜λŠ” 경우, 센터에 μœ„μΉ˜ν•˜μ§€ μ•ŠλŠ” 였λ₯˜ μˆ˜μ • (사싀 μ„œλ²„μ—μ„œ 1개만 쀄리가 μ—†κ³  μ—λŸ¬λ‚˜λ©΄ 빈 배열이라 λ³Ό 일 μ—†μŒ)
  • μ•„ν‹°μŠ€νŠΈ 상세 flip() ν•¨μˆ˜ λ‚΄ 둜직 μ€‘λ³΅μ½”λ“œ κ°„μ†Œν™”
  • 기타 μž‘λ‹€ν•œ μ½”λ“œ 정리

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

λ”±νžˆ μ—†μŒ.

βœ… PR 체크리슀트

ν…œν”Œλ¦Ώ 체크리슀트 말고도 μΆ”κ°€μ μœΌλ‘œ ν•„μš”ν•œ μ²΄ν¬λ¦¬μŠ€νŠΈλŠ” μΆ”κ°€ν•΄μ£Όμ„Έμš”!

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@github-actions github-actions bot added 🐞 Bug 버그 κ΄€λ ¨ ♻️ Refactor μ½”λ“œ λ¦¬νŒ©ν† λ§ labels Apr 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions GitHub Actions
Copy link

βœ… Assign μžλ™ 지정을 μ„±κ³΅ν–ˆμ–΄μš”!

@KangTaeHoon

baekteun
baekteun reviewed Apr 24, 2024
View reviewed changes
Projects/Features/ArtistFeature/Sources/ViewControllers/ArtistDetailHeaderViewController.swift
)
}
func flipArtistIntro() {
descriptionFrontView.isHidden = descriptionFrontView.isHidden ? false : true
Copy link
Member

@baekteun baekteun Apr 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
descriptionFrontView.isHidden = descriptionFrontView.isHidden ? false : true
descriptionFrontView.isHidden = !descriptionFrontView.isHidden

μ‚Όν•­μ—°μ‚°μžλ‘œ μ–΄λ–€κ°€μš”? μ•„λž˜λž‘λ„ μŠ€νƒ€μΌ 맞좜겸용

@KangTaeHoon KangTaeHoon merged commit e120318 into develop Apr 26, 2024
3 checks passed
@KangTaeHoon KangTaeHoon deleted the 494-refactoring-artist branch April 26, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baekteun baekteun baekteun approved these changes

@youn9k youn9k youn9k approved these changes

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

Assignees

@KangTaeHoon KangTaeHoon

Labels
🐞 Bug 버그 κ΄€λ ¨ ♻️ Refactor μ½”λ“œ λ¦¬νŒ©ν† λ§
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

♻️ :: μ•„ν‹°μŠ€νŠΈ νŽ˜μ΄μ§€ λ¦¬νŒ©ν† λ§
4 participants
@KangTaeHoon @yongbeomkwak @youn9k @baekteun